Giter Club home page Giter Club logo

Comments (3)

marcelklehr avatar marcelklehr commented on May 27, 2024

It appears hard links don't require admin rights: https://github.com/npm/fstream/blob/master/lib/link-writer.js#L34

from decompress.

kevva avatar kevva commented on May 27, 2024

@marcelklehr, could you try running from master and see if that fixes your issue?

from decompress.

Skn0tt avatar Skn0tt commented on May 27, 2024

Hey folks! I've hit an issue that I believe is related to this. Given a ZIP that contains a directory symlink, decompress on Windows will try recreating it as a hardlink. This will fail, because hardlinks don't support linking between directories. Symlinks do, though!

What do you think about only using hardlinks as a fallback if the symlink fails, e.g. because of missing admin permissions?
Kinda like this:

if (x.type === 'symlink') {
	return fsP.symlink(x.linkname, dest).catch((err) => {
             if (process.platform === 'win32' && err is because of missing admin permissions) {
                 fsP.link(dest, path.join(dest, "..", x.linkname))
             }
             throw err
        });
}

Happy to provide a PR if you think something like this is viable.

from decompress.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.