Giter Club home page Giter Club logo

Comments (10)

doomedraven avatar doomedraven commented on June 18, 2024 1

nah, thats totally fine, thanks again for spotting all those things. This is huge help for us

from capev2.

maxzhenzhera avatar maxzhenzhera commented on June 18, 2024 1

тепер моя черга дякувати)

from capev2.

maxzhenzhera avatar maxzhenzhera commented on June 18, 2024

One more question to conf.py:

CAPE version declared in the docs:

# The short X.Y version.
version = "2.1"
# The full version, including alpha/beta/rc tags.
release = "2.1"

differs from the real version:
CUCKOO_VERSION = "2.4-CAPE"


I think a good solution for it would be to import that constant in conf.py (optionally stripping the CAPE suffix).

from capev2.

maxzhenzhera avatar maxzhenzhera commented on June 18, 2024

Not to open another issue - will ask here:
It seems strange that after installing CAPE using sudo ./cape2.sh base cape - mongodb reporting is disabled (default).
I saw #1729 as related to my question.

But my point is that it looks kinda inconsistent.
If mongodb setup is provided by script, maybe:

  • indicate in reporting.conf docs: if you used sudo ./cape2.sh base cape then turn mongodb reporting on manually
  • or do this step above in installation script (smth like sed enabled=on)

from capev2.

doomedraven avatar doomedraven commented on June 18, 2024
  1. About theme, yes it was unintentional, i will test your proposal
  2. That conf version is just for docs and i guess it comes from old cuckoo, i will see how to change that in near future
  3. About mongo, well before we were activating that too, but after some discussion(can't remember context why) we decided to not force that to end user

is totally fine to use the same issue for extra questions, so if you got any, let us know

from capev2.

doomedraven avatar doomedraven commented on June 18, 2024

pinned theme, but i guess im just sleepy as i don't see change

from capev2.

maxzhenzhera avatar maxzhenzhera commented on June 18, 2024
  1. Great job - read the docs has been applied

  2. OK, up to you

but after some discussion(can't remember context why) we decided to not force that to end user

I decided to look across commits and find some more information.
But what I accidentally found is installer code that is opposing to reality:

CAPEv2/installer/cape2.sh

Lines 1205 to 1208 in c2dae18

# default is enabled, so we only need to disable it
if [ "$MONGO_ENABLE" -lt 1 ]; then
crudini --set conf/reporting.conf mongodb enabled no
fi

Cause by default it is disabled:
[mongodb]
enabled = no

So, it looks like we should invert the behavior of this if clause.

from capev2.

doomedraven avatar doomedraven commented on June 18, 2024

yes you know, when people PR stuff and they didn't change properly all places and you didn't remember that neither. so thanks for checking. updated cape2.sh

from capev2.

maxzhenzhera avatar maxzhenzhera commented on June 18, 2024

I apologize if my message sounded accusatory.
I fully understand the nature of the code changes)

from capev2.

kevoreilly avatar kevoreilly commented on June 18, 2024

Big love ❤️

from capev2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.