Comments (4)
This is most likely a problem with your fetching logic. And since you did not provide a repro, I'm just going to close this.
from material-react-table.
@KevinVandy I cannot reproduce it because MRT doesnt seem to work in Stackblitz or Codesandbox:
- https://codesandbox.io/p/devbox/github/KevinVandy/material-react-table/tree/v2/apps/material-react-table-docs/examples/remote/sandbox?file=%2Fsrc%2Fmain.tsx%3A10%2C1
- https://stackblitz.com/github/KevinVandy/material-react-table/tree/v2/apps/material-react-table-docs/examples/remote/sandbox?file=src%2FTS.tsx
PS: I am 100% positive it is not coming from my implementation, it only does that with min/max. It is basically adding the filter for min/max with undefined values:
[ { "id": "adjustedPrice", "value": [ undefined, undefined ] }, { "id": "recommendedPrice", "value": [ undefined, undefined ] }, { "id": "currentPrice", "value": [ undefined, undefined ] }, { "id": "brand", "value": [ "ACTION" ] } ]
If the filter value is empty for both min and max, it should be removed from the filter state, right ?
from material-react-table.
@jerlam06 It works perfectly fine. You'll just have to mock your own API returns in a sandbox. To make a reproduction, you just have to prove that some state is causing a re-render of some other unrelated state that it is not supposed to.
from material-react-table.
@KevinVandy Ok thanks. I could reproduce it there => https://stackblitz.com/edit/github-8arb9x?file=src%2FTS.tsx
Open the dev console and trigger show/hide filters, show filters triggers a filter state change for no reason. Plus, the min/max filters remain in the filter state even when empty, this is not consistent I believe.
Thanks in advance, and very good job with the v2, it is amazing :)
from material-react-table.
Related Issues (20)
- using MRT and mui/material <TextField in a component make <TextField typing slow and lag. HOT 1
- Error with accessorFn on nested props with v2.12.0 onwards
- React Material Table v2-> columnVisibility attribute accepts wrong type in initialState
- Scroll Position Jumps when scroll stops and row gets hovered HOT 5
- Row selection callback called multiple times when using grouping
- 2 elements in DOM with non unique id #mrt-rows-per-page HOT 1
- Show/Hide Columns popup menu not keyboard accessible
- Inline edit demo lags when `onBlur` is triggered HOT 1
- Do not trim header when column width is too small HOT 2
- Row ordering with row virtualization HOT 2
- onSortingChange getting called twice on first render (reopened) HOT 1
- The sx property in the muiTableHeadCellsProps in the column definitions overwrites the same property in the table instance HOT 1
- Text Field: Characters Duplicated on Enter When Confirming Composition HOT 1
- Header checkbox does not get selected when selecting page with grouped data HOT 1
- Total rows not tally when selecting rows when grouping is active
- Screenreaders read all elements like sorting every time the user navigates inside the table HOT 3
- After setting `onColumnFilterFnsChange`, the `Filter Mode` of the column header is displayed incorrectly, and always display fuzz. HOT 3
- Support Material UI v6 HOT 2
- Vitest stopped working after v3 HOT 4
- Cannot use import statement outside a module in MRT 3.0.0 HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from material-react-table.