Comments (8)
@MarekPatyna It seems that the full locale name is ukUA
from my understanding. That's what Material UI itself names their locale. And usually its fine to just refer to it by the first 2 letters, unless there are multiple dialects.
![image](https://private-user-images.githubusercontent.com/28243511/308422104-18e2ad3a-7cd1-4124-b68a-f1309dbaa037.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg1NDAzNDksIm5iZiI6MTcxODU0MDA0OSwicGF0aCI6Ii8yODI0MzUxMS8zMDg0MjIxMDQtMThlMmFkM2EtN2NkMS00MTI0LWI2OGEtZjEzMDlkYmFhMDM3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjE2VDEyMTQwOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWM2MTFkYzZiZWY5MDg0MDE2Mjk5YmY3NjVjZWY5Y2E4N2EzMGZiN2JlZGY3NWI1ZDFiNDhkMDdhNGM2NDRkOWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.I3MNkSmfMsgQoNtRE-qIsu9DxAGT6CgwRSs0C4aLw5s)
I always refer to this website when checking: https://saimana.com/list-of-country-locale-code/
![image](https://private-user-images.githubusercontent.com/28243511/308422590-7128910e-04ee-4fe9-9f05-5202b127ac17.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg1NDAzNDksIm5iZiI6MTcxODU0MDA0OSwicGF0aCI6Ii8yODI0MzUxMS8zMDg0MjI1OTAtNzEyODkxMGUtMDRlZS00ZmU5LTlmMDUtNTIwMmIxMjdhYzE3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjE2VDEyMTQwOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWZlNWE4ODFhZjdmNTEwNmNlYzc0MzY0NGJlOWRjNzZlYzdiYWE4YTliNjk5NTc3OTRhYjUxMGI5NDBiZGUyNTEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.rSUorMDkcZ75mGHN8nKP1cPncPcRpKf8YStLAzX9Zsk)
from material-react-table.
Thank you for your reply. Unfortunately but I did not see that Ukrainian was created because I was sure that "uk" corresponds to United Kingdom. In my opinion and from what I checked on the internet the ISO abbreviation for Ukrainian is UA or possibly UKR but not UK.
https://www.andiamo.co.uk/resources/iso-language-codes/
https://laendercode.net/en/country/ua
https://www.iso.org/obp/ui/#iso:code:3166:UA
https://en.wikipedia.org/wiki/ISO_3166-2:UA
from material-react-table.
@MarekPatyna Your translations seem to be a lot different than the current uk locale in MRT. Which one is more correct? The existing one or yours?
![image](https://private-user-images.githubusercontent.com/28243511/308423267-ae7b2b89-ad88-40a8-afbf-b20777f9d70e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg1NDAzNDksIm5iZiI6MTcxODU0MDA0OSwicGF0aCI6Ii8yODI0MzUxMS8zMDg0MjMyNjctYWU3YjJiODktYWQ4OC00MGE4LWFmYmYtYjIwNzc3ZjlkNzBlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjE2VDEyMTQwOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRhYzc5ZWQ2YjI4MTY3YTc5MDdmMDY1MmY1MjIzZTQ5OWIyZGRmYWIzNGM2NTczZjUzOWZmZTUwMzdmZjJkYjImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.8QhxVLpQe2qSuzc9H9Dp49UCR8AqoONF0GDj3EJo4pk)
from material-react-table.
Yeah for sure, just make a PR in the same format as the current uk
locale`.
https://github.com/KevinVandy/material-react-table/blob/v2/packages/material-react-table/src/locales/uk.ts
btw, what's the difference between uk
and ua
?
from material-react-table.
I don't speak Ukrainian at b2/c1+ level, so I would personally suggest leaving the current translation. Thanks for the quick replies and good luck with MRT development!
from material-react-table.
I always refer to this website when checking: https://saimana.com/list-of-country-locale-code/
And if a language isn't there, its more comprehensive source is https://iso639-3.sil.org/code_tables/639/data.
from material-react-table.
Thank you for your reply. Unfortunately but I did not see that Ukrainian was created because I was sure that "uk" corresponds to United Kingdom. In my opinion and from what I checked on the internet the ISO abbreviation for Ukrainian is UA or possibly UKR but not UK.
https://www.andiamo.co.uk/resources/iso-language-codes/
https://laendercode.net/en/country/ua
https://www.iso.org/obp/ui/#iso:code:3166:UA
https://en.wikipedia.org/wiki/ISO_3166-2:UA
@MarekPatyna To clarify, the ISO 3166-2 code you were seeing for Ukraine (UA) is the country code, not the language code: https://en.wikipedia.org/wiki/ISO_3166#Parts
from material-react-table.
Apologies for writing back so late but I completely forgot about this issue. Thank you again @imnasnainaec @KevinVandy for your help.
Best regards!
from material-react-table.
Related Issues (20)
- Can we drag a column using column header instead of drag icon in Material-React-Table?
- Infinite Scrolling - Infinite Loop of loading and stop scrolling after set maxPages in useInfiniteQuery HOT 2
- MRT Grid Infinite scrolling with RTk Query HOT 1
- Inability to Drag Columns on Tablets, Mobiles, or Touch Devices HOT 1
- MUI style breaking in UI HOT 1
- Column editSelectOptions array with label and value do not select label in edit mode HOT 1
- Strange Scrolling behaviour with Header Groups and column virtualization HOT 1
- muiPaginationProps does not include rowsPerPage HOT 2
- onColumnVisibilityChange behaves strange when clicked the show menu column showAll or hideAll button HOT 2
- When using `localStorage` or `sessionStorage` to store filter values, I'm encountering an error specifically with the `filterVariant` set to "date" or "date-range": HOT 5
- Column Ordering (DnD) not working on mobile device HOT 1
- Min, Max and Median functions not working properly on dataset with null values
- sort on null value HOT 3
- Group columns are too small when enableColumnResizing:true
- Missing InputLabel when filter is a Select, variant is outlined, in custom filter ui
- Change the text of buttons in edit modal HOT 1
- When selecting "Empty" or "Not Emtpy" with multi-select results in TypeError: selected.map is not a function HOT 1
- how to access staticRowIndex inside AggregatedCell HOT 3
- pageCount:-1 does not seem to work as intended
- "enableRowVirtualization" doesn't work correctly with MRT_Table component HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from material-react-table.