Comments (9)
Maybe a full fix?
This fixes the admin interfaces from crashing for ACF6.
https://github.com/MGParisi/acf-star-rating-field
I'm uncertain if there is more. It's working for me now on ACF6 non-pro again. Though, I'm only using it on the front end.
from acf-star-rating-field.
@jarrod-collective
Check out my fork, it resolves the issues.
https://github.com/MGParisi/acf-star-rating-field
from acf-star-rating-field.
@MGParisi Hey, I'll take a look at this over the weekend and hopefully get it fixed.
from acf-star-rating-field.
I'm experiencing the same issue. Looks like something goes wrong with the SVG rendering as well. Is this plugin still maintained @kevinruscoe ? It's a very helpful piece of code 😀
from acf-star-rating-field.
Doesn't work with ACF non-pro either, and seems to be now crashing ACF admin interface.
I started looking at it, and there is a function render_field which creates a <script> tag with the initialization of that field in it. For some reason, this doesn't seem to be getting added in the Custom Fields of the Admin. This causes an Error and breaks it.
I think this issue is for all of ACF 6. The javascript needs to fail in a way it doesn't cause the javascript to fail.
from acf-star-rating-field.
acf-star-rating-field/StarRatingField.php
Line 102 in 3166fd5
from acf-star-rating-field.
Also, SVG's work for me. That is incorrect. Only the SVG's from Font-Awesome are not working (according to the ticket)
from acf-star-rating-field.
I'm sorry, but I can't replicate the issues.
I've just installed:
- WP 6.1
- ACF
- this plugin (from the master branch).
I made a simple star field and created a minimal theme
<?php
wp_head();
while(have_posts()) {
the_post();
the_title();
print get_field('star');
}
wp_footer();
And all 3 return types (number, list and FA list) work.
Can you guys provide more context, please?
from acf-star-rating-field.
Hi @kevinruscoe,
I've just come across this issue as well. For me, it was working up until trying to duplicate items in the field group. At that point, after refreshing, I was no longer able to edit fields until disabling the plugin.
from acf-star-rating-field.
Related Issues (20)
- Rated by user HOT 1
- Making rating required? HOT 3
- Star outline icon is not working HOT 1
- Please consider loading inline svg instead of fa icons in wp admin HOT 2
- Is this also for frontend user rating? HOT 1
- ACF not supported in Products List View
- Don't Work HOT 3
- Update to Font Awesome 5? HOT 1
- Tag new release
- JS not working when adding star rating field to comment form HOT 1
- Add support for ACF's conditional logic
- Add a theme option HOT 4
- Required field HOT 2
- Star Rating field is not available in REST API
- PHP warning when return type is non-numeric
- Does not work with SVG Font Awesome kits
- Add Rest Api support to the plugin. Solution
- How to form a star rating in a post using a shortcode?
- Can't use 'Add rule group' and 'Conditional logic' for anything with this plugin enabled HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from acf-star-rating-field.