Giter Club home page Giter Club logo

Comments (9)

MGParisi avatar MGParisi commented on June 28, 2024 2

Maybe a full fix?

This fixes the admin interfaces from crashing for ACF6.
https://github.com/MGParisi/acf-star-rating-field

I'm uncertain if there is more. It's working for me now on ACF6 non-pro again. Though, I'm only using it on the front end.

from acf-star-rating-field.

MGParisi avatar MGParisi commented on June 28, 2024 2

@jarrod-collective
Check out my fork, it resolves the issues.
https://github.com/MGParisi/acf-star-rating-field

from acf-star-rating-field.

kevinruscoe avatar kevinruscoe commented on June 28, 2024 1

@MGParisi Hey, I'll take a look at this over the weekend and hopefully get it fixed.

from acf-star-rating-field.

dhunink avatar dhunink commented on June 28, 2024

I'm experiencing the same issue. Looks like something goes wrong with the SVG rendering as well. Is this plugin still maintained @kevinruscoe ? It's a very helpful piece of code 😀

from acf-star-rating-field.

MGParisi avatar MGParisi commented on June 28, 2024

Doesn't work with ACF non-pro either, and seems to be now crashing ACF admin interface.

I started looking at it, and there is a function render_field which creates a <script> tag with the initialization of that field in it. For some reason, this doesn't seem to be getting added in the Custom Fields of the Admin. This causes an Error and breaks it.

I think this issue is for all of ACF 6. The javascript needs to fail in a way it doesn't cause the javascript to fail.

from acf-star-rating-field.

MGParisi avatar MGParisi commented on June 28, 2024

public function render_field($field)

from acf-star-rating-field.

MGParisi avatar MGParisi commented on June 28, 2024

Also, SVG's work for me. That is incorrect. Only the SVG's from Font-Awesome are not working (according to the ticket)

from acf-star-rating-field.

kevinruscoe avatar kevinruscoe commented on June 28, 2024

I'm sorry, but I can't replicate the issues.

I've just installed:

  • WP 6.1
  • ACF
  • this plugin (from the master branch).

I made a simple star field and created a minimal theme

<?php 

wp_head();

while(have_posts()) {
    
    the_post();

    the_title();

    print get_field('star');

}

wp_footer();

And all 3 return types (number, list and FA list) work.

Can you guys provide more context, please?

from acf-star-rating-field.

jarrod-colluco avatar jarrod-colluco commented on June 28, 2024

Hi @kevinruscoe,

I've just come across this issue as well. For me, it was working up until trying to duplicate items in the field group. At that point, after refreshing, I was no longer able to edit fields until disabling the plugin.

from acf-star-rating-field.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.