Comments (13)
KevinDockx
commented on July 26, 2024
What would be needed to make this possible? My main concern is breaking outer facing stuff, so if it doesn't I'd be inclined to go for it :)
from httpcacheheaders.
SeanFarrow
commented on July 26, 2024
I don’t think removing the second dictionary will break outer facing stuff, but it’s not something I’d be looking at for this release.
In terms of what needs serializing, we need to serialize both the key/value in a key/value pair to the final string, currently only the values are serialized and joined.
The only other alternative is to have a type that derives from KeyStore for the distributed stores and do the serialization required there.
I’m open to either approach.
From: Kevin Dockx ***@***.***>
Sent: Wednesday, February 15, 2023 8:07 AM
To: KevinDockx/HttpCacheHeaders ***@***.***>
Cc: Sean Farrow ***@***.***>; Author ***@***.***>
Subject: Re: [KevinDockx/HttpCacheHeaders] Allow StoreKey to be rehydrated (Issue #114)
What would be needed to make this possible? My main concern is breaking outer facing stuff, so if it doesn't I'd be inclined to go for it :)
—
Reply to this email directly, view it on GitHub<#114 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AALDK7VJC34WV64QRAUBWKTWXSFC3ANCNFSM6AAAAAAU34YZ3A>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
from httpcacheheaders.
KevinDockx
commented on July 26, 2024
Serializing both is ok as far as I'm concerned, gives us a unified approach. Do you need me to do that, or will you take this up?
from httpcacheheaders.
SeanFarrow
commented on July 26, 2024
It depends when you want to get v7 out, I’m not going to get to this before Tuesday as we’re just doing a release.
I’m happy to do it though if your not in a rush as I’m blocked without it really!
Thanks
From: Kevin Dockx ***@***.***>
Sent: Friday, February 17, 2023 7:33 AM
To: KevinDockx/HttpCacheHeaders ***@***.***>
Cc: Sean Farrow ***@***.***>; Author ***@***.***>
Subject: Re: [KevinDockx/HttpCacheHeaders] Allow StoreKey to be rehydrated (Issue #114)
Serializing both is ok as far as I'm concerned, gives us a unified approach. Do you need me to do that, or will you take this up?
—
Reply to this email directly, view it on GitHub<#114 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AALDK7RIEOHZB7K7I6SSZSTWX4SUNANCNFSM6AAAAAAU34YZ3A>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
from httpcacheheaders.
KevinDockx
commented on July 26, 2024
There's no rush :)
from httpcacheheaders.
SeanFarrow
commented on July 26, 2024
OK, I’ll stick this on my list.
From: Kevin Dockx ***@***.***>
Sent: Friday, February 17, 2023 7:41 AM
To: KevinDockx/HttpCacheHeaders ***@***.***>
Cc: Sean Farrow ***@***.***>; Author ***@***.***>
Subject: Re: [KevinDockx/HttpCacheHeaders] Allow StoreKey to be rehydrated (Issue #114)
There's no rush :)
—
Reply to this email directly, view it on GitHub<#114 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AALDK7VYGOYQA6QG2ZNYJVTWX4TQTANCNFSM6AAAAAAU34YZ3A>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
from httpcacheheaders.
KevinDockx
commented on July 26, 2024
Hi Sean, do you happen to have an idea of when you'll be able to work on this PR? Thanks! :)
from httpcacheheaders.
SeanFarrow
commented on July 26, 2024
I have some holiday after the 05/05, so I’m hoping to work on it then.
Thanks,
Sean.
From: Kevin Dockx ***@***.***>
Sent: Monday, April 24, 2023 1:14 PM
To: KevinDockx/HttpCacheHeaders ***@***.***>
Cc: Sean Farrow ***@***.***>; Author ***@***.***>
Subject: Re: [KevinDockx/HttpCacheHeaders] Allow StoreKey to be rehydrated (Issue #114)
Hi Sean, do you happen to have an idea of when you'll be able to work on this PR? Thanks! :)
—
Reply to this email directly, view it on GitHub<#114 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AALDK7VRSYJTF3C4S7G2CITXCZVBNANCNFSM6AAAAAAU34YZ3A>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
from httpcacheheaders.
KevinDockx
commented on July 26, 2024
That sounds good, thanks!
from httpcacheheaders.
SeanFarrow
commented on July 26, 2024
@KevinDockx Do we want to spin up a Docker container for Redis in the tests to check that we can retrieve the keys a user would expect given the pattern we are matching and whether we are ignoring case?
I ask as to retrieve the keys, we have to look at each server, which unfortunately doesn't have an interface, so this isn't really mockable.
from httpcacheheaders.
KevinDockx
commented on July 26, 2024
If you wish, sure, but I wouldn't go that far - seems like a bit of overkill just to get a few additional automated tests.
from httpcacheheaders.
SeanFarrow
commented on July 26, 2024
I've now raised a PR for this.
Once this is merged, I can finish off #112.
from httpcacheheaders.
SeanFarrow
commented on July 26, 2024
Closed by #115
from httpcacheheaders.
Related Issues (20)
- Disable caching for error responses HOT 5
- Provide the ability to ignore caching by default HOT 7
- Provide a way to store validator values in a scalable manner HOT 18
- Use the IAsyncEnumerable interface in the FindStoreKeysByKeyPartAsync method of the IValueStore interface HOT 4
- Remove all unsupported tfm's HOT 4
- Update all out-of-date NuGet packages HOT 6
- Should we migrate away from Moq HOT 1
- Make the StoreKey object round-trippable HOT 5
- Use the InMemoryCache rather than a custom dictionary HOT 9
- Add tests for methods that don't have them in the InMemoryValidatorValueStore
- Add .Net 8 and use the .Net 8 RC1 SDK HOT 1
- Support Cancellation tokens
- Swappable input implementations for eTag generation HOT 2
- InMemoryValidatorValueStore is no longer thread safe HOT 1
- Nullable (& other) language improvements
- Redis Distributed CacheKeyRetriever not returning set on keys command HOT 1
- Clean up csproj & optimise dependencies
- 7.1.0 contains bug when HttpCacheExpiration and HttpCacheValidation attributes are applied on controller and on action HOT 1
- Middleware returns 304 when DisableGlobalHeaderGeneration = true and StoreKey is MarkForInvalidation
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from httpcacheheaders.