Giter Club home page Giter Club logo

Comments (4)

cpiaulet avatar cpiaulet commented on June 11, 2024

I found in models/ the ExpRampModel model that seems to do what we would expect of an exponential model (with the coefficients), and updated test_exponentialmodel() definition in test_lightcurve_fitting.py according to how the model is defined in models/.

When running pytest again, everything seems to run smoothly now!
I will submit a pull request for this small edit

from eureka.

jbrande avatar jbrande commented on June 11, 2024

Thanks for catching this, @cpiaulet! I think it's technically my responsibility to fix the tests. I just pulled down the most recent version and verified the issue exists, but I've got some other problem which makes the straight substitution fail. I'll bring this up in the meeting today.

from eureka.

jbrande avatar jbrande commented on June 11, 2024

Actually, this is fine and I see Kevin already approved the PR. That can go ahead and get merged!

from eureka.

kevin218 avatar kevin218 commented on June 11, 2024

I'm going to merge the PR now and close this issue.

from eureka.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.