Comments (4)
I found in models/ the ExpRampModel
model that seems to do what we would expect of an exponential model (with the coefficients), and updated test_exponentialmodel()
definition in test_lightcurve_fitting.py according to how the model is defined in models/.
When running pytest
again, everything seems to run smoothly now!
I will submit a pull request for this small edit
from eureka.
Thanks for catching this, @cpiaulet! I think it's technically my responsibility to fix the tests. I just pulled down the most recent version and verified the issue exists, but I've got some other problem which makes the straight substitution fail. I'll bring this up in the meeting today.
from eureka.
Actually, this is fine and I see Kevin already approved the PR. That can go ahead and get merged!
from eureka.
I'm going to merge the PR now and close this issue.
from eureka.
Related Issues (20)
- Improve documentation for white LC joint fits
- [Enhancement]: Further clarify manual_clip conventions on ECF documentation page HOT 1
- White light curve with times all zero HOT 3
- [Bug]: S4 wave_1d_trimmed variable HOT 2
- [Enhancement]: Use single median frame for all segments HOT 3
- [Bug]: Current code/documentation incompatible with exotic-ld v3
- [Bug]: WFC3 Exposure Counting HOT 13
- [Bug]: NoDataOnDetectorError HOT 4
- [Enhancement]: Automatically skip completely masked lightcurves in S5
- [Bug]: Resurfacing of S3 NaN masking bug
- Stage 2: (FATAL) CRDS server connection and cache load FAILED HOT 6
- ERROR: FAILED BUILDING WHEEL FOR DRIZZLE HOT 1
- [Bug]: Installation on M2-chip Mac Book Pro fails with ERROR: Failed building wheel for numpy HOT 6
- [Bug]: Not compatible with Colab HOT 2
- [Bug]: Too short wavelength range from NIRSpec G395H data HOT 9
- [Bug]: GPs not working HOT 7
- [Bug]: S3 Plotting Requires Matplotlib >=3.6
- [Bug]: Certain spec_hw values seem to break HST S3 reduction HOT 3
- [Enhancement]: Quickstart for HST WFC3/G141 S3-S6 stages HOT 1
- [Enhancement]: add Eureka! version to log and meta file HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eureka.