Review about modern-react HOT 4 CLOSED

Oh, also, I'm currently getting into an infinite loop in the Suspense stuff.

Here's the block of code that's triggering the infinite loop in the test:

If you make this return Promise.reject() then you can reproduce the infinite loop in the app:

Help there would be super appreciated :)

Here's the code for where that's all happening: https://github.com/kentcdodds/modern-react/blob/master/src/exercises-final/11.js

(Note: I do plan to teach and recommend react-cache (see 12, 13, and 14), I just like to start as simple as possible so people understand what's going on fundamentally).

from modern-react.

Oh, and exercise 15 doesn't work yet because you can't currently use Hooks in React.pure. @acdlite mentioned that's an oversight and will be fixed, either way a review of that is appreciated as well :)

from modern-react.

11.js: You probably want to cache the promise so you don't ever do two fetches for the same name. Would the error boundary and placeholder be better in Usage? Generally people err on the side of coupling Placeholders too tightly with individual fetches and we want to discourage that.

12.js/13.js: Best practices on passing down a cache are TBD and might change in the next two weeks.

14.js: Maybe teach React.lazy before other types of suspense? It's easier to wrap your head around I think.

from modern-react.

All great tips @sophiebits! Thank you!

from modern-react.