Proxy all events about cross-env HOT 14 CLOSED

🐒

from cross-env.

Yep, for Windows anyways. Don't have OSX/Linux to test with

from cross-env.

Thanks for reporting this. Would you be willing to makeapullrequest.com to fix it?

from cross-env.

Hm, maybe, I'm not quite sure how best to handle it. Quick untested idea:

const signals = ['SIGTERM', 'SIGINT', 'SIGPIPE', 'SIGBREAK', 'SIGWINCH'];

function crossEnv(args) {
  // Stuff
  signals.forEach((signal) => {
    process.on(signal, (...eventArgs) => proc.emit.apply(proc, eventArgs));
  });
}

Though that won't proxy other events and needs to be updated if Node adds more signals

from cross-env.

I'm fine with that approach. Is there any internal module we can use that has that list of signals so we don't have to update in the future?

from cross-env.

If not, I'm good hardcoding it and keeping it updated.

from cross-env.

There isn't a built-in event list that I can see no. However, I find it unlikely that they'll add signals, since it's just following the standard POSIX signaling spec

from cross-env.

Another option would be to use something like https://github.com/asyncly/EventEmitter2 and wrap process, or, injecting process.emit with a function call to patch the event through

from cross-env.

you're suggesting using onAny from EventEmitter2? Seems interesting. Though I think I actually like monkey-patching process.emit a little better.

from cross-env.

Yes, though I think using EventEmitter2 is a bit overkill for this

from cross-env.

Agreed. Let's monkey-patch process.emit 👍

from cross-env.

I'll get a PR up later this week, need to fix the tests

from cross-env.

So while testing various things on how best to do this (also wanted to see about proxy'ing all events) I've noticed that the current version of the module actually leaves zombie processes behind, as the child process isn't killed when the parent process is killed (at least on Windows).

Seems it's because Windows sends a SIGINT signal on kill usually, rather than SIGTERM

Gonna PR for adding all the kill signals then, then see how to handle all events.

The way the tests are set up makes it a bit tricky to test, especially with the way Node handles exit events, so I'm not sure I can get to 100% tested, but we'll see..

from cross-env.

I've noticed that the current version of the module actually leaves zombie processes behind

So this is resolved as part of your merged PR too right?

from cross-env.