buildListItem always returns NaN as finishDate and E13C6 has a bug in test about bookshelf HOT 6 CLOSED

Interesting! Thank you for digging into this!

So yeah, this is a bit of a bummer. The correct fix is simple, but will require a slightly different approach to the test. Here's the fix:

- finishDate = faker.date.between(startDate, new Date()).getTime(),
+ finishDate = faker.date.between(new Date(startDate), new Date()).getTime(),

The problem is this will require changing the test a bit which would require I re-record the video. Not a huge deal, but a bit of a bummer.

from bookshelf.

Here's the update that I think should be made to the test for this:

+ const user = await loginAsUser()
+ const book = await booksDB.create(buildBook())
+ const listItem = await listItemsDB.create(
+   buildListItem({owner: user, book, finishDate: null}),
+ )
+ await renderBookScreen({user, book, listItem})
+
- const {listItem} = await renderBookScreen()
-
- // set the listItem to be unread in the DB
- await listItemsDB.update(listItem.id, {finishDate: null})

I'm going to give this some thought. I think I'll need to rerecord the video before I make these changes.

Thanks again for reporting this!

from bookshelf.

@all-contributors please add @milamer for bugs

from bookshelf.

@kentcdodds

I've put up a pull request to add @milamer! 🎉

from bookshelf.

I've updated the main branch to have this correction. An update to the exercise will come in the future.

from bookshelf.

The video that needs an update is this one: https://epicreact.dev/modules/build-an-epic-react-app/integration-testing-extra-credit-solution-06

It's a relief that only one video is impacted, but a bummer that it's one of the longer ones 😅 I'll put this on my list though. Thanks again!

from bookshelf.