Giter Club home page Giter Club logo

Comments (3)

porjo avatar porjo commented on July 2, 2024 2

This would be one way to achieve it which keeps the current behaviour by default and doesn't break the API

from sanitize.

kennygrant avatar kennygrant commented on July 2, 2024

Sound sensible. Would it be acceptable to have package globals to set things like separator or other default options?

We'd need to keep the current behaviour and make this optional of course.

from sanitize.

kennygrant avatar kennygrant commented on July 2, 2024

I had a think about this last year, and the reason I haven't done it is that it would make the interface not thread safe in a non-obvious way. You might be tempted to set the globals each time before calling the function, which would not be safe in a goroutine (i.e. in a server). The Separator might be safe as a global if it's clearly documented I guess, because you're likely only to set it once.

Re lowercase, I think better would be to add functions which preserve case, but I'm not sure on naming. I prefer to avoid mixed case in file names because of varying treatment on file systems like Mac OS or linux which can cause subtle bugs.

So on balance I'm going to close this one for the above reasons. Sorry it took so long and thanks for the suggestions.

from sanitize.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.