Comments (2)
pklaes
commented on August 9, 2024
1
Beware, _.has(langJson, "locale") returns false if langJson is null, whereas langJson.locale throws a type error. So although I'm all for vanilla JS and against dependency creep, I would probably not refactor and just live with it.
If I were to rewrite, I would use simply
if (langJson && langJson.locale && langJson.locale.android)
since this is most javascriptish and a value of "" or 0 for any of these wouldn't help us either.
from cordova-plugin-localization-strings.
rodrigograca31
commented on August 9, 2024
I agree but I hate dependencies and nowadays we depend on stuff for no reason, this is perfect example.
But yeah I may just live with it because I got better stuff to do then removing 1 dependency in this project 😂
from cordova-plugin-localization-strings.
Related Issues (20)
- What is the default language if there are 2 languages specified HOT 1
- Plugin not working on Release Build iOS HOT 9
- Execution failed for task ':app:mergeDebugResources'. HOT 3
- Doesn't work in Phonegap Build (https://build.phonegap.com) HOT 3
- Not getting localized strings on iOS 13 HOT 2
- Custom TRANSLATION_PATH not working or ignored HOT 3
- creating localisation with "-" fails on android HOT 2
- How to set fallback language HOT 3
- npm audit failes with 5 vulnerabilities (4 low, 1 moderate) HOT 4
- Force Android resConfigs HOT 1
- If missing config_android, then empty strings.xml will be created
- Prepare fails on iOS with "Error: Cannot read properties of undefined (reading 'project')" HOT 3
- Cordova plugin version is still on 3.2.1 HOT 3
- (iOS) Does not support encoded characters in project name (&) HOT 2
- projectFile import will break in cordova-ios@7 HOT 1
- Version 5.0.0 - 5.0.2 regex broken on Windows HOT 6
- Automatic tests HOT 1
- Possible VoltBuilder woes
- Installing the latest version causes an error → EUNSUPPORTEDPROTOCOL HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cordova-plugin-localization-strings.