Comments (3)
Hi, thank you for your feedback.
I understand what you need but no, this cannot be added without losing the main purpose of the plugin.
You can choose whether to add a CSS class to these links or code them manually.
Am I missing something? How can any program tell your tracking links from your internal links? Is there anything that distinguishes them?
from jekyll-target-blank.
It should be easy to distinguish them as all the external links start with /go (or whatever path a particular site uses, I think both /go and /out are quite common)
- yourdomain.com/go/something --> external
- yourdomain.com/something --> internal
So in the plugin you'd just need the ability to set a path that is used for external redirects.
Do you understand what I mean?
from jekyll-target-blank.
I understand. Thank you for clarifying.
This feature can be made possible with using a regexp in Jekyll's config.
I'm sorry that I don't have time to implement this at the moment. However, if you give it a go, I'll review your PR asap.
You can look at my code, the parts that change behaviour depending on CSS class names and work from there.
- Describe the feature in the SPEC file.
- Write code for the spec to pass.
- Nudge the minor version number forward.
- Submit PR
- Fix and build issues.
- I'll approve or comment on the PR.
- I'll upload the Gem to RubyGems (asap).
Thank you once again.
PS: this was my first ever ruby code so I'm sure you can also do it π
from jekyll-target-blank.
Related Issues (20)
- 1.2.0 doesn't work with Jekyll v4 HOT 3
- Add hostname white list to skip adding rel attributes HOT 12
- In 2.0.0: undefined method `match?' for "/":String (NoMethodError) HOT 2
- css tag for *not* modifying external links HOT 2
- Error: bad URI(is not URI?): http://localhost:4000 HOT 7
- Plugin isnβt working HOT 22
- _config file must have the url entry HOT 3
- do not ovewrite custom attributes e.g. {:rel="sponsored"} HOT 8
- Be able to exclude some pages
- Make the plugin work with Markdown only HOT 1
- Remove rel="noopener noreferrer" from default config HOT 2
- Intel Mac -- Arm64 Nokogiri... HOT 1
- Plugin not working unless the gem is added to the group :jekyll_plugins section HOT 3
- Not working (with Github Pages) HOT 1
- exclude specific external links HOT 2
- Remove CI checks so that we can merge the PRs. HOT 1
- Cannot build Jekyll site HOT 7
- Not working when URL constructed from site data HOT 3
- Causes HTML named character entities to be rendered incorrectly HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jekyll-target-blank.