Giter Club home page Giter Club logo

Comments (3)

keithmifsud avatar keithmifsud commented on June 3, 2024

Hi, thank you for your feedback.

I understand what you need but no, this cannot be added without losing the main purpose of the plugin.

You can choose whether to add a CSS class to these links or code them manually.

Am I missing something? How can any program tell your tracking links from your internal links? Is there anything that distinguishes them?

from jekyll-target-blank.

tkrunning avatar tkrunning commented on June 3, 2024

It should be easy to distinguish them as all the external links start with /go (or whatever path a particular site uses, I think both /go and /out are quite common)

  • yourdomain.com/go/something --> external
  • yourdomain.com/something --> internal

So in the plugin you'd just need the ability to set a path that is used for external redirects.

Do you understand what I mean?

from jekyll-target-blank.

keithmifsud avatar keithmifsud commented on June 3, 2024

I understand. Thank you for clarifying.

This feature can be made possible with using a regexp in Jekyll's config.

I'm sorry that I don't have time to implement this at the moment. However, if you give it a go, I'll review your PR asap.

You can look at my code, the parts that change behaviour depending on CSS class names and work from there.

  1. Describe the feature in the SPEC file.
  2. Write code for the spec to pass.
  3. Nudge the minor version number forward.
  4. Submit PR
  5. Fix and build issues.
  6. I'll approve or comment on the PR.
  7. I'll upload the Gem to RubyGems (asap).

Thank you once again.

PS: this was my first ever ruby code so I'm sure you can also do it πŸ˜‰

from jekyll-target-blank.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.