Giter Club home page Giter Club logo

Comments (3)

p0358 avatar p0358 commented on May 20, 2024 1

NVM, it still appears to be global for the whole parser. Fuck me...

from binary-parser.

ElbowBaggins avatar ElbowBaggins commented on May 20, 2024

I know this is probably too late for you, but hopefully it helps someone.

When Parser invokes your formatter, it does so with Function.prototype.apply() and passes itself as the this argument. As a result, the function is now running in the context of the Parser and not the lexical context that you are expecting.

I addressed this by adding a $imports property to Parser.prototype where one could add anything they'd like to make available from within the Parser's context. Basically, using the above example, you want something like this.

const Parser = require('binary-parser').Parser;
const moment = require('moment');
Parser.prototype.$imports = {
    moment: moment
};

let time = function(timestamp) {
    return this.$imports.moment(timestamp, 'YYMMDDHHmmssSS').format('YYYY-MM-DD HH:mm:ss.SS');
};

let Telegram = new Parser().string('timestamp', { encoding: 'hex', length: 7, formatter: time });

You can use this approach to inject pretty much whatever you want in there.

from binary-parser.

p0358 avatar p0358 commented on May 20, 2024

Here's what appears to be possible, if you want to add a property to specific Parser object, and not a global:

let opts = parser.encoderOpts;
opts.test = "test";
parser.encoderSetOptions(opts);

parser = parser.array(name, {
    /* ... */
    formatter: item => this.encoderOpts.test
});

(this would replace all objects there to "test", but it shows that it's indeed accessible this way)
[you might also be interested in related comment in #33]

from binary-parser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.