Buffer is not defined on generated code calling compiled about binary-parser HOT 6 CLOSED

+1

from binary-parser.

Buffer needs to be defined globally (e.g. on window) at runtime because binary-parser creates code and calls it with eval.

from binary-parser.

Fixed with a workaround :-(

Using grunt:

'string-replace': {
            dist: {
                files: {
                    './dist/js/ABC.js': './dist/js/ABC.js'
                },
                options: {
                    replacements: [{
                        pattern: 'if (!Buffer.isBuffer(buffer)) {',
                        replacement: 'if (false) {'
                    }]
                }
            }
        },

I know is not very elegant, but it does the trick

from binary-parser.

@riggs did not understand where to define the buffer.
Currently as a workaround I removed the check of isBuffer from the code but I am looking for something more elegant

`

// ctx.pushCode('if (!Buffer.isBuffer(buffer)) {');
// ctx.generateError('"argument buffer is not a Buffer object"');
// ctx.pushCode('}');

if (!this.alias) {
    this.addRawCode(ctx);
} else {
    this.addAliasedCode(ctx);`

from binary-parser.

Has anyone figured out a cleaner solution for this? I too manually comment out those 3 lines, but whenever I set up a new enlistment I need to remember doing it again.
Plus, new folks working on my project also need to know about it.

FWIW, I'm in a browser environment (Electron or Cordova) and need to polyfill Buffer (which works perfectly fine after commenting out those lines).

from binary-parser.

The code is ran at line 322
within this context, we just need to import and provide the Buffer object in another context.
var Buffer = require("buffer").Buffer;
this.compiled = vm.runInNewContext(src,{Buffer});
I will open a pull request

from binary-parser.