Giter Club home page Giter Club logo

Comments (7)

bohwaz avatar bohwaz commented on September 3, 2024

You have to manually configure the WWW_URL constant inside the config.local.php, as KaraDAV has no way of detecting the server address this way.

For example for testing I use:

const WWW_URL = 'http://192.168.43.171:8080/';

from karadav.

archef2000 avatar archef2000 commented on September 3, 2024

Yeah but would it not be better to have auto detection on the client side in case of a proxy or port mapping like docker.

from karadav.

bohwaz avatar bohwaz commented on September 3, 2024

There's auto-detection on the server side currently, the client cannot be trusted or it might open to flaws like open redirects.

I added instructions in INSTALL.md on how to configure WWW_URL accordingly.

If you have better detection code, then you're welcome for a PR, thank you :)

from karadav.

archef2000 avatar archef2000 commented on September 3, 2024

Because i dont see any client to server comunication for the path that is needed you cloud just use window.location.origin on the client which has no open redirect vuln

from karadav.

bohwaz avatar bohwaz commented on September 3, 2024

The redirect happens on the server side, so there is no safe way to get the URL from the client in a trusted way.

from karadav.

archef2000 avatar archef2000 commented on September 3, 2024

So why not just use a client side javascript and sanatize it before display.

from karadav.

bohwaz avatar bohwaz commented on September 3, 2024

There is no way to do that safely.

from karadav.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.