Comments (4)
What is the expected behavior in this case?
from iproute.
I think that the expected behavior is for the invalid address to fail to parse.
it "does not read overflow IPv4 octets" $ do
(readMay "127.0.0.18446744073709551617" :: Maybe IPv4) `shouldBe` Nothing
I wrote a fix and discovered that the problematic dig
function is used to parse mask lengths as well.
λ: import Data.IP (AddrRange, IPv4)
λ: print @(AddrRange IPv4) $ read "192.168.0.1/18446744073709551648"
192.168.0.1/32
I think that this should fail to parse as well.
it "does not read overflow mask lengths" $ do
(readMay "192.168.0.1/18446744073709551648" :: Maybe (AddrRange IPv4)) `shouldBe` Nothing
I wrote a fix for this as well.
I will submit my fixes as a PR. If you have any suggestions or requests, please let me know.
from iproute.
I think that the expected behavior is for the invalid address to fail to parse.
This makes sense to me!
from iproute.
Closing.
from iproute.
Related Issues (20)
- iproute-1.4.0 failed during the building phase. - Not in scope: foldl' HOT 1
- Integer <-> IPv4 HOT 1
- iproute-1.6.0 fails to compile with GHC 7.0, 7.2 and 7.4 HOT 2
- Add a variant of IPRange that does not mask the IP automatically HOT 1
- What about better fail information from `read`?
- Type-safe from/to helper functions HOT 2
- Split Data.IP and Data.IP.RouteTable into separate packages? HOT 2
- Add parse from ByteString HOT 4
- Literal 4294967295 is out of the Int range -2147483648..2147483647 on 32bit systems HOT 4
- Redundant constraint warnings.
- Combined IPRTable-like type for both IPv4 and IPv6 HOT 3
- IPRTable memory use HOT 6
- iproute-1.7.6 test suite failures HOT 2
- GHCJS compilation HOT 1
- GHCJS compilation fail HOT 4
- iproute-1.7.10 fails to compile on pre-8.0 versions of GHC
- Test suite failure for package iproute-1.7.10 HOT 1
- I made a Hackage revision for iproute 1.7.9 HOT 1
- Missing instances for some domain types
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from iproute.