eless: Doesn't preserve view-mode when opening file from dired about eless HOT 9 CLOSED

Thanks. You might like the new q binding with this change too ( 2f23f9c ). I made commits in the wrong order.. this commit was made before the above referenced, but it makes more sense in the reverse order.

from eless.

@alphapapa I believe this issue is fixed. Feel free to re-open it if needed.

from eless.

Strange that you mention that :)

I am specifically disabling view-mode if dired-mode is detected. My main reason for doing that is because the view-mode-map keys shadowed many useful bindings in dired-mode-map. As dired-mode is anyways a special-mode, it is "read-only" by default (i.e. it is not a normal editable file buffer), there is no need to enable view-mode.

I though have a feeling why this question was raised.. hitting q does not seem to behave as a "less" substitute if the mode is dired-mode. I have fixed that in 7a0f741.

(define-key dired-mode-map (kbd "q") (quote save-buffers-kill-emacs))

from eless.

Hm, well, what I mean is, if I'm thinking of eless as a "better less," then when I use it to view a file from its built-in dired mode, I would expect it to view that file in a read-only view mode, not regular Emacs editor mode. :)

I though have a feeling why this question was raised.. hitting q does not seem to behave as a "less" substitute if the mode is dired-mode. I have fixed that in 7a0f741.

That's a good idea.

from eless.

But the dired-mode is a read-only mode. It becomes "writeable" only when wdired is enabled.

from eless.

Sorry, what I mean is:

1. User runs eless ., which opens a dired buffer.
2. User presses RET on a text file (not necessarily txt).
3. The file is now opened in normal, writable mode. This seems contrary to the purpose of eless, to view files, and to require manual intervention to disable read-only-mode.

from eless.

Thanks for that explanation..

If I bind RET to dired-view-file (bound to v by default), would that solution work?

from eless.

Try updating to the latest e5f5363

from eless.

Thanks, that's great.

from eless.