Make the Dexter API fluent about dexter HOT 4 CLOSED

Awesome idea!
I would personally prefer a more semantic or granular API, such as

public void someMethod() {
    Dexter.forPermissions(Manifest.permission.CAMERA, Manifest.permission.READ_CONTACTS)
          .doOnGranted(someListener)
          .doOnDenied(errorListener)
          .doWhenRationaleShouldBeShown(someListener)
          .onSameThread()
          .check();
}

It's just my personal and maleable opinion. But the idea of a fluent API is great.

from dexter.

I can see why you'd separate the doWhenRationaleShouldBeShown callback but I can't think of any use case where you wouldn't handle at least the two basic responses, doOnGranted and doOnDenied. Anyways, you can always create a composite listener with a generic onDenied listener and specific onGranted implementations, actually, you can do the same with the rationale callback as well.

In this case, I'd rather keep a single interface than splitting it into three for three reasons: it's easier to implement, it's easier to understand (IMHO) and we can move towards simpler interfaces whenever we want keeping it backwards compatible (but not the other way around!).

from dexter.

Yep you're right, it doesn't make much sense implementing only one of the two callbacks. I was thinking more on lambda support. Two methods with one functional interface can use lambdas, but one method with a two method interface can't.
But of course, at the current state of Android, lambda support should not be a priority for an API design :p

Maybe a middle solution would be a RxJava-like listener supporting both forms, one interface with two methods and two interfaces with one method.

Anyway, just that you have thought about it is good enough for me. The real advantage here is the fluent API \o/

from dexter.

@Serchinastico do you have a branch to implement this one? Could be great to publish the 3.0.0 version with my last PR #73 and this one.

from dexter.