Comments (6)
I found out that offset in drain and lastOffset is the same value
from hyper-express.
Yeah, I used to actually have that sliced chunk being served for backpressuring but it's a very weird implementation and it turned out that chunk slicing was not needed because the write()
method buffers the chunk under the hood anyways. So essentially, you should serve the next chunk after backpressure relieves rather than serve the same chunk but sliced. If you find this behavior to be incorrect, feel free to link the test code to recreate the bug in hyper-express
and I'd be glad to push a fix.
from hyper-express.
The issue is stream hangs on slow internet connection when streaming a few megabytes in few files. I'm using this method stream
to stream static files, the issue appears when I'm testing it on a production server over internet. So you may try to reproduce it by serving multiple large images over network (you may try to throttle the bandwidth in browser devtools). It may appear in future when you will be developing a middleware for static files serving
from hyper-express.
I see, I'll try to recreate this myself. If you end up writing a snippet to simulate this bug with high probability feel free to share.
from hyper-express.
I think i finally fixed this method issues for both: streams with size and without size
from hyper-express.
I think i finally fixed this method issues for both: streams with size and without size
Great! Feel free to make a PR and I'd be glad to have it implemented.
from hyper-express.
Related Issues (20)
- `res.cookie` is incompatible with express HOT 1
- A build error appeared with version 6.14.2 with TypeScript types definition HOT 1
- How to use `compression`? HOT 6
- Can't handle error in global error handler
- Default Encoding problems with accents HOT 1
- HI kartik, I'm sorry for the stupid question, but I need to learn how to work with this by example, can you show me?) HOT 3
- Handling multiple multipart HOT 7
- Question: Is there support for HTTP3 / QUIC ? HOT 1
- Feature request: swagger HOT 1
- No error thrown if invalid json is sent as body HOT 4
- From version 6.0.0, the response component doesn´t call a close or abort event when the SSE client is closed HOT 1
- Nest-hyper-express-adapter middleware tests failing HOT 4
- Nest-hyper-express instance and local-pipes tests each fail one test HOT 3
- Outdated example of static serving / LiveDirectory HOT 1
- Error: uWS.HttpResponse must not be accessed after uWS.HttpResponse.onAborted callback HOT 1
- Graceful shutdown HOT 4
- Static serving HOT 1
- No error on binding to the same port HOT 1
- No Socket Received From uWebsockets.js likely due to an invalid host or busy port. HOT 2
- Optional Parameter Route HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hyper-express.