Clone PDU about kdis HOT 10 CLOSED

You could just call Encode and Decode using the PDU_Factory although it's more work than a straight copy.

from kdis.

@karljj1 Can we try to implement this

What do you think?

from kdis.

@karljj1 Can we try to implement this

What do you think?

This would involve adding a clone method to every PDU and DataType? It should be fine, just quite a bit of work ;)

from kdis.

See https://github.com/CppCodeReviewers/Covariant-Return-Types-and-Smart-Pointers

This is mind blowing

from kdis.

Looks interesting. I did avoid using some of the newer c++ features because I know some of the users of kdis were running it on a 20 year old toaster, but it may be time to embrace them 😄

from kdis.

With the refactor we've set the minimum C++ standard as 11.
Therefore, we should be good with this one

from kdis.

We should probably get rid of my old smart pointer then, if you haven't already 😄

from kdis.

Done in the previous PR

from kdis.

@karljj1 It's correct that Reliability_Header does not extend Header? Am I missing somethig? Thanks

from kdis.

Yes Reliability header is only for PDU that support it, the PDU tend to be in a special reliable category. So instead we use multiple inheritance to add it in when needed.

from kdis.