Giter Club home page Giter Club logo

Comments (15)

johnysandels avatar johnysandels commented on June 15, 2024 1

I've just checked all of those bugs, and it seems like everything is working!
Beautiful work!

from texttotalk.

karashiiro avatar karashiiro commented on June 15, 2024

Can you be more specific on the /echo thing? I thought I was able to replicate this, but it turned out that the Echo chat type was just disabled.

from texttotalk.

karashiiro avatar karashiiro commented on June 15, 2024

Also, can you provide an error from the log for the deleting the plugin?

from texttotalk.

johnysandels avatar johnysandels commented on June 15, 2024

Yeah definitely!

dalamud.log

from texttotalk.

karashiiro avatar karashiiro commented on June 15, 2024

That one's fixed, will merge with goatcorp/DalamudPlugins#971, no clue on the /echo issue yet, though.

from texttotalk.

johnysandels avatar johnysandels commented on June 15, 2024

Just checked echo, I turned it on and the first messages worked and all messages after didn't work.

from texttotalk.

karashiiro avatar karashiiro commented on June 15, 2024

Might be related to #37? If so we should revisit this one after 1.8.0.2 is merged.

from texttotalk.

johnysandels avatar johnysandels commented on June 15, 2024

This is with my lexicons disabled. It might have something to do with #35 and the queue order. I can load it up tonight to see if it's fixed.

from texttotalk.

karashiiro avatar karashiiro commented on June 15, 2024

My PR is still open, so I'll just drop this here in case you happen to have time for it 🙂

latest.zip

from texttotalk.

johnysandels avatar johnysandels commented on June 15, 2024

Deleting the plugin is fixed, echo is fixed. text queueing is working at expected.

chat text triggered between dialogue boxes uses the gendered voice of the dialogue speaker.

When disabling the plugin by toggle, chat speech was stopped, and the first dialogue speech was stopped, but the second dialogue box read out.

Also your revert to reset the speaker mentioned in #35, is either not part of this update, or I was not able to make it work.

from texttotalk.

karashiiro avatar karashiiro commented on June 15, 2024

The speaker reset works for me, but I'll look into it further just in case. The other issues seem to be caused by the system backend not always responding to speech cancellation requests - the Polly backend doesn't seem to have these issues. Looking into that right now.

from texttotalk.

johnysandels avatar johnysandels commented on June 15, 2024

For me it resets once the final dialogue box is closed, but doesn't reset between dialogue boxes.

from texttotalk.

karashiiro avatar karashiiro commented on June 15, 2024

For me it's the exact opposite 😄 I think that it's really just a result of how much time is being spent between dialogue advances, though.

from texttotalk.

karashiiro avatar karashiiro commented on June 15, 2024

I think I finally have a fix, will drop a link in a minute.

from texttotalk.

karashiiro avatar karashiiro commented on June 15, 2024

latest.zip

Here's the new build I'm PRing, let me know how it works 👍

from texttotalk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.