Giter Club home page Giter Club logo

Comments (20)

tbg avatar tbg commented on September 13, 2024

Unfortunately, building for darwin-10.11 does not fix the issue (same errors).

from xgo.

tbg avatar tbg commented on September 13, 2024

Here's the output with -x -v (for darwin-10.11):
https://gist.github.com/tschottdorf/d44f3f2edea9f454aee0b82178372bb2

from xgo.

tbg avatar tbg commented on September 13, 2024

A more compact failing invocation is

xgo --targets=darwin-10.11/amd64 --go=1.6 github.com/elastic/gosigar

from xgo.

karalabe avatar karalabe commented on September 13, 2024

Ufff, dang. I'll take a look.

from xgo.

tbg avatar tbg commented on September 13, 2024

Thanks, appreciated. Let me know if I can help.

from xgo.

karalabe avatar karalabe commented on September 13, 2024

Hmmm, seems that Apple moved /usr/include/c++/v1 out of the SDK on 10.11 :| Not sure how to work around it yet.

from xgo.

tamird avatar tamird commented on September 13, 2024

Looks like there's some relevant discussion in ycm-core/ycmd#254

from xgo.

tamird avatar tamird commented on September 13, 2024

Testing this locally, looks like $(xcrun --show-sdk-path)/usr/include might be the most reliable option.

from xgo.

karalabe avatar karalabe commented on September 13, 2024

Already testing the fix :)

from xgo.

karalabe avatar karalabe commented on September 13, 2024

$ xgo --targets=darwin-10.11/amd64 --go=1.6.1 github.com/elastic/gosigar
$ ls -al
-rw-r--r-- 1 root root 314650 Apr 13 18:33 gosigar-darwin-10.11-amd64

from xgo.

tbg avatar tbg commented on September 13, 2024

Cool. If you don't mind, try against github.com/cockroachdb/cockroach as well (should take <15min).

from xgo.

karalabe avatar karalabe commented on September 13, 2024

Just did, something failed but I'm doing a second pass now.

from xgo.

karalabe avatar karalabe commented on September 13, 2024

Ok, an hour of debug later I realized that 10.6 doesn't have c++11 :P Building now with 10.11 to see it my fix was actually good all along.

from xgo.

karalabe avatar karalabe commented on September 13, 2024
-rwxr-xr-x  1 root     root     37627320 Apr 13 19:18 cockroach-darwin-10.11-amd64

from xgo.

tbg avatar tbg commented on September 13, 2024

👍

from xgo.

karalabe avatar karalabe commented on September 13, 2024

Fixed by 647f256 :)

I've polished up the patch a bit, did a second run against cockroach with 10.9. All green.

-rwxr-xr-x  1 root     root     37627320 Apr 13 19:18 cockroach-darwin-10.11-amd64
-rwxr-xr-x  1 root     root     37627320 Apr 13 19:32 cockroach-darwin-10.9-amd64

I've pushed the changes. Please allow up to a few hours for docker hub to crunch through the changes and see if this resolves the issue. Please leave this ticket open until then :)

Thanks for the report!

from xgo.

tbg avatar tbg commented on September 13, 2024

Thanks for the fix! Btw, I don't see any testing in this repo - it's easy enough to set up (at least on CircleCI, but probably also on TravisCI and others at this point). See https://github.com/cockroachdb/cockroach/blob/master/build/build-osx.sh (which is what we call from our circle.yml)

from xgo.

tbg avatar tbg commented on September 13, 2024

works locally, thanks!

from xgo.

karalabe avatar karalabe commented on September 13, 2024

@tschottdorf I wrote a small test suite for xgo to run before pushing out new changes. I've added a few smoke tests, all the go-ethereum builds as well as the darwin-10.9/amd64 build of cockroachdb. Are you guys using xgo for other platforms too? I'd gladly add them to my test suite to ensure I don't screw up your builds next time I develop something :)

from xgo.

tbg avatar tbg commented on September 13, 2024

Thanks Péter! darwin-10.9/amd64 is currently all we're building (with xgo).
We'll make sure to let you know when we're tackling other platforms.

On Mon, Apr 18, 2016 at 10:35 AM Péter Szilágyi [email protected]
wrote:

@tschottdorf https://github.com/tschottdorf I wrote a small test suite
for xgo to run before pushing out new changes. I've added a few smoke
tests, all the go-ethereum https://github.com/ethereum/go-ethereum
builds as well as the darwin-10.9/amd64 build of cockroachdb. Are you
guys using xgo for other platforms too? I'd gladly add them to my test
suite to ensure I don't screw up your builds next time I develop something
:)


You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#44 (comment)

from xgo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.