Visibility issue with Challenge newtypes about webauthn-rs HOT 7 CLOSED

Inside the crate we can just use challenge.0 though can't we?

from webauthn-rs.

Yes, internally nothing has changed, but Challenge is a type that is exposed publicly, and for whatever reason a user might want to make use of the inner data in the Challenge in a different context (ex: serializing). Currently, the change I've made is a regression, as before the inner byte vector was just pub.

from webauthn-rs.

I think that people shouldn't be tampering with the challenges that we generate though, so I'm happy that this is "hidden". There are actually some issues under discussion in the webauthn group about this, and people "mis-using" the challenge field to sign arbitrary data, but it actually weakens the system.

from webauthn-rs.

w3c/webauthn#1595

from webauthn-rs.

Interesting. I think that is reasonable.
I would think that having a public new(bytes: Vec<u8>) function would be problematic if we wish to prevent users from placing arbitrary data in the challenge. Perhaps that should be made pub(crate) instead?

from webauthn-rs.

Yes, I think so :)

from webauthn-rs.

Thanks!

from webauthn-rs.