The sqlite documentation for

It's <a href="https://kanidm.github.io/kanidm/stable/database_maint.html?highlight=dat

SQLite Write-Ahead Logging might make page size immutable about kanidm HOT 3 CLOSED

TheRealGramdalf commented on June 9, 2024

SQLite Write-Ahead Logging might make page size immutable

from kanidm.

Comments (3)

yaleman commented on June 9, 2024

It's already documented that you need to vacuum after changing the db_fs_type, but I've added a PR to note it on the config entry ref too.

from kanidm.

TheRealGramdalf commented on June 9, 2024

I did see that, but that's not the part I'm worried about - it says that "It is not possible to change the page_size after entering WAL mode, either on an empty database or by using VACUUM"

Unless I'm horribly incorrect, this means that once created (and WAL mode is enabled, which I assume is the case due to the .db-wal file), you cannot change the page size with a vacuum.

The only exception that I can see (though I am no expert in sql) is "You must be in a rollback journal mode to change the page size."

from kanidm.

yaleman commented on June 9, 2024

And that's why we disable the WAL mode journalling on vacuum. ref

kanidm/server/lib/src/be/idl_sqlite.rs

Lines 1801 to 1833 in 307a66e

 vconn 

 .pragma_update(None, "journal_mode", "DELETE") 

 .map_err(|e| { 

 admin_error!(?e, "rusqlite journal_mode update error"); 

 OperationError::SqliteError 

 })?; 

 vconn.close().map_err(|e| { 

 admin_error!(?e, "rusqlite db close error"); 

 OperationError::SqliteError 

 })?; 

 let vconn = 

 Connection::open_with_flags(cfg.path.as_str(), flags).map_err(sqlite_error)?; 

 vconn 

 .pragma_update(None, "page_size", cfg.fstype as u32) 

 .map_err(|e| { 

 admin_error!(?e, "rusqlite page_size update error"); 

 OperationError::SqliteError 

 })?; 

 vconn.execute_batch("VACUUM").map_err(|e| { 

 admin_error!(?e, "rusqlite vacuum error"); 

 OperationError::SqliteError 

 })?; 

 vconn 

 .pragma_update(None, "journal_mode", "WAL") 

 .map_err(|e| { 

 admin_error!(?e, "rusqlite journal_mode update error"); 

 OperationError::SqliteError 

 })?;

from kanidm.

Recommend Projects

SQLite Write-Ahead Logging might make page size immutable about kanidm HOT 3 CLOSED

Comments (3)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	vconn
	.pragma_update(None, "journal_mode", "DELETE")
	.map_err(\|e\| {
	admin_error!(?e, "rusqlite journal_mode update error");
	OperationError::SqliteError
	})?;

	vconn.close().map_err(\|e\| {
	admin_error!(?e, "rusqlite db close error");
	OperationError::SqliteError
	})?;

	let vconn =
	Connection::open_with_flags(cfg.path.as_str(), flags).map_err(sqlite_error)?;

	vconn
	.pragma_update(None, "page_size", cfg.fstype as u32)
	.map_err(\|e\| {
	admin_error!(?e, "rusqlite page_size update error");
	OperationError::SqliteError
	})?;

	vconn.execute_batch("VACUUM").map_err(\|e\| {
	admin_error!(?e, "rusqlite vacuum error");
	OperationError::SqliteError
	})?;

	vconn
	.pragma_update(None, "journal_mode", "WAL")
	.map_err(\|e\| {
	admin_error!(?e, "rusqlite journal_mode update error");
	OperationError::SqliteError
	})?;