outlet_caps relating to feature availability about aiounifi HOT 5 CLOSED

What are your thoughts on "shimming" these caps definitions into the expected properties?

for example:

    @property
    def has_relay(self) -> bool | None:
        """Is the outlet controllable."""
        has_relay = self.raw.get("has_relay")
        if has_relay == None:
            outlet_caps = self.raw.get("outlet_caps")
            has_relay = outlet_caps == 3 or outlet_caps == 1 
        return has_relay

uses the property that comes back from the API if it's available. if it's not, it uses caps to determine the result.

So right now Im not a fan of trying put too much logic into the library but rather try to keep it close to what the API exposes. I think its better we combine this data on the integration side of things.

from aiounifi.

What are your thoughts on "shimming" these caps definitions into the expected properties?
for example:

    @property
    def has_relay(self) -> bool | None:
        """Is the outlet controllable."""
        has_relay = self.raw.get("has_relay")
        if has_relay == None:
            outlet_caps = self.raw.get("outlet_caps")
            has_relay = outlet_caps == 3 or outlet_caps == 1 
        return has_relay

uses the property that comes back from the API if it's available. if it's not, it uses caps to determine the result.

So right now Im not a fan of trying put too much logic into the library but rather try to keep it close to what the API exposes. I think its better we combine this data on the integration side of things.

Other PR proposing a composite way to cover relay support https://github.com/Kane610/aiounifi/pull/185/files

from aiounifi.

I think its sound to define it like this!

from aiounifi.

What are your thoughts on "shimming" these caps definitions into the expected properties?

for example:

    @property
    def has_relay(self) -> bool | None:
        """Is the outlet controllable."""
        has_relay = self.raw.get("has_relay")
        if has_relay == None:
            outlet_caps = self.raw.get("outlet_caps")
            has_relay = outlet_caps == 3 or outlet_caps == 1 
        return has_relay

uses the property that comes back from the API if it's available. if it's not, it uses caps to determine the result.

from aiounifi.

In that case, I'll update my PR to only document the caps

from aiounifi.