Preserve context values about retry HOT 5 CLOSED

Hi! Yes, retry.Do doesn't preserve context values when calling action because it expects strategy.Breaker, not context.Context.

It is possible to do that:

-	ctx, cancel := context.WithCancel(context.Background())
+	ctx, is := breaker.(context.Context)
+	if !is {
+		ctx = context.Background()
+	}
+	ctx, cancel := context.WithCancel(ctx)

I'm not a fan of the Value part of the context, but could you provide some use cases to make a decision.

from retry.

Hi Kamil,

I am used to storing correlation id in context so it gets prepended to all log entries. For instance when I am building a REST API, I use request id as correlation id and I can then easily inspect all log entries produced by a request even if they are interleaved with other entries. That's how I found out retry.Do isn't preserving values - correlation id was missing from some log entries. There are other ways to do it of course, but projects I work on do it like that.

Database transaction handle also gets stored in context.

from retry.

Thanks, Bojan! I'm preparing the patch and will add some tests to it.

Today it will be ready, the upcoming release is v5.0.0-rc6.

from retry.

Thank you very much!

from retry.

https://github.com/kamilsk/retry/releases/tag/v5.0.0-rc6

from retry.