Giter Club home page Giter Club logo

Comments (4)

GoogleCodeExporter avatar GoogleCodeExporter commented on July 21, 2024
Ok, updated to just use the mangled name if demangling fails.  With this patch, 
I
diffed the output of the existing dump_syms and my new one on firefox-bin, and 
the
only differences are in displaying std::string vs. std::basic_string<...>:

5509c5509
< FUNC f124 97 0
google_breakpad::ExceptionHandler::ExceptionHandler(std::basic_string<char,
std::char_traits<char>, std::allocator<char> > const&, bool (*)(void*), bool 
(*)(char
const*, char const*, void*, bool), void*, bool)
---
> FUNC f124 97 0 google_breakpad::ExceptionHandler::ExceptionHandler(std::string
const&, bool (*)(void*), bool (*)(char const*, char const*, void*, bool), 
void*, bool)
5907c5907
< FUNC 10982 12d 0
google_breakpad::MinidumpGenerator::UniqueNameInDirectory(std::basic_string<char
,
std::char_traits<char>, std::allocator<char> > const&, std::basic_string<char,
std::char_traits<char>, std::allocator<char> >*)
---
> FUNC 10982 12d 0
google_breakpad::MinidumpGenerator::UniqueNameInDirectory(std::string const&,
std::string*)
6305c6305
< FUNC 11dd8 1a7 0 MacStringUtils::IntegerValueAtIndex(std::basic_string<char,
std::char_traits<char>, std::allocator<char> >&, unsigned int)
---
> FUNC 11dd8 1a7 0 MacStringUtils::IntegerValueAtIndex(std::string&, unsigned 
int)

The new lines are the output of my new tool.  I think that looks nicer anyway!

Original comment by ted.mielczarek on 2 May 2007 at 3:42

Attachments:

from google-breakpad.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 21, 2024
Wow, I didn't know that cxa_demangle was available in libstdc++.  I complained 
during
the initial review of the Mac dump_syms that we didn't have access to this 
function
because we didn't really have access to libiberty.

Original comment by [email protected] on 2 May 2007 at 3:57

  • Added labels: Component-Tool-SymConverter, OpSys-OSX

from google-breakpad.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 21, 2024

Original comment by ted.mielczarek on 3 May 2007 at 8:15

  • Added labels: Type-Patch
  • Removed labels: Type-Defect

from google-breakpad.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 21, 2024
adding one more fix:

    buffer = abi::__cxa_demangle(symbol, buffer, &buffer_size, &result);

buffer needs to be assigned from the return result of __cxa_demangle to deal 
with realloc...

Checking fix in...

Original comment by [email protected] on 3 May 2007 at 10:59

  • Changed state: Fixed

from google-breakpad.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.