Giter Club home page Giter Club logo

Comments (2)

kaivi avatar kaivi commented on May 29, 2024

Tested it a bit. Indeed it does trigger change(), but only once on first focus and only on RIENumber. Will get back to it when I'm using the lib again.

from riek.

FizzyGalacticus avatar FizzyGalacticus commented on May 29, 2024

This happens because of the comparison taking place in RIEStatefulBase:

if(result && this.props.value !== newValue)
    this.commit(newValue);

It's using the !== comparator, which compares types of the objects as well. Since the initial value is presumably a number, but the new value becomes a string, they are treated as different.

Changing comparison to != automatically converts both to the same type, and the validation checks out.

I'm not sure if this is the best way to do it, although I don't see anything inherently wrong with this, since we're just dealing with text/numbers.

I'll submit a PR.

from riek.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.