Hi, thanks for making it clear that you store the token (a lot of the other devs d

Please update documentation with reference of file which stores the API Token about obsidian-raindrop-highlights-plugin HOT 4 CLOSED

kaiiiz commented on August 17, 2024

Please update documentation with reference of file which stores the API Token

from obsidian-raindrop-highlights-plugin.

Comments (4)

kaiiiz commented on August 17, 2024

As the document mentioned, it's stored in the browser's localStorage. This is not stored in any file that can be synced across devices.

To many people are sharing their vault and their .obsidian directory 😀

Yes, this caused a serious security risk. To the best of my knowledge, storing the token in the localStorage is the best trade-off between security and convenience, unless obsidian provides a more advanced API for storing sensitive information.

from obsidian-raindrop-highlights-plugin.

dredhorse commented on August 17, 2024

uups.. now I see it, so I need to add the api token to every device.
Cumbersome but better then to store the api in a plain text file, I agree.
Didn't read through the code enough to see if there is a message poping up if the token is not there.

from obsidian-raindrop-highlights-plugin.

kaiiiz commented on August 17, 2024

Didn't read through the code enough to see if there is a message poping up if the token is not there.

obsidian-raindrop-highlights-plugin/src/api.ts

Lines 18 to 21 in bf3dd33

 const token = this.tokenManager.get(); 

 if (!token) { 

 throw new Error("Invalid token"); 

 }

Token checking logic is at the beginning of the API request, and the error will be resolved in the syncCollection function.

obsidian-raindrop-highlights-plugin/src/sync.ts

Lines 33 to 49 in bf3dd33

 async syncCollection(collection: SyncCollection) { 

 new Notice(`Sync Raindrop collection: ${collection.title}`); 

 const highlightsFolder = this.plugin.settings.highlightsFolder; 

 const collectionFolder = `${highlightsFolder}/${collection["title"]}`; 

 const lastSyncDate = this.plugin.settings.syncCollections[collection.id].lastSyncDate; 

 let articles: RaindropArticle[] = []; 

 try { 

 console.debug('start sync collection:', collection.title, "last sync at:", lastSyncDate); 

 articles = await this.api.getRaindropsAfter(collection.id, lastSyncDate); 

 await this.syncArticles(articles, collectionFolder); 

 await this.syncCollectionComplete(collection); 

 } catch (e) { 

 console.error(e); 

 new Notice(`Sync Raindrop collection ${collection.title} failed: ${e.message}`); 

 } 

 }

I'm considering moving the checking logic inside the get function of tokenManager.

from obsidian-raindrop-highlights-plugin.

dredhorse commented on August 17, 2024

ah, thanks for this information

from obsidian-raindrop-highlights-plugin.

Please update documentation with reference of file which stores the API Token about obsidian-raindrop-highlights-plugin HOT 4 CLOSED

Comments (4)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	const token = this.tokenManager.get();
	if (!token) {
	throw new Error("Invalid token");
	}

	async syncCollection(collection: SyncCollection) {
	new Notice(`Sync Raindrop collection: ${collection.title}`);
	const highlightsFolder = this.plugin.settings.highlightsFolder;
	const collectionFolder = `${highlightsFolder}/${collection["title"]}`;
	const lastSyncDate = this.plugin.settings.syncCollections[collection.id].lastSyncDate;

	let articles: RaindropArticle[] = [];
	try {
	console.debug('start sync collection:', collection.title, "last sync at:", lastSyncDate);
	articles = await this.api.getRaindropsAfter(collection.id, lastSyncDate);
	await this.syncArticles(articles, collectionFolder);
	await this.syncCollectionComplete(collection);
	} catch (e) {
	console.error(e);
	new Notice(`Sync Raindrop collection ${collection.title} failed: ${e.message}`);
	}
	}