Giter Club home page Giter Club logo

Comments (9)

burmanm avatar burmanm commented on May 25, 2024 1

@tomereli Applying --set in the command line resets the previous settings to defaults. From helm help:

--reuse-values when upgrading, reuse the last release's values and merge in any overrides from the command line via --set and -f. If '--reset-values' is specified, this is ignored

Thus, your previous setting of:

--set ingress.traefik.enabled=true

If set to false after you applied the --set size=3. To keep the previous ingress values, you need to apply the --reuse-values to your later upgrades. So, the size upgrade would be:

helm upgrade k8ssandra-cluster-a k8ssandra/k8ssandra-cluster --set size=3 --reuse-values

That is assuming the behavior is the same as before as described better in this article:

https://medium.com/@kcatstack/understand-helm-upgrade-flags-reset-values-reuse-values-6e58ac8f127e

from k8ssandra.

jeffbanks avatar jeffbanks commented on May 25, 2024 1

@jeffbanks I think you were in process of verifying this? Could you send update to the doc or should I?

@burmanm I will take care of updating the documentation to avoid future confusion. Thanks for the additional information here to assist @tomereli.

from k8ssandra.

jsanda avatar jsanda commented on May 25, 2024

@jeffbanks Can you take a look at this?

from k8ssandra.

jeffbanks avatar jeffbanks commented on May 25, 2024

Yes, researching and reaching out to get more information regarding commands in steps 5 & 6.

from k8ssandra.

jeffbanks avatar jeffbanks commented on May 25, 2024

Hi @tomereli can you provide some more details for us to further investigate?

What commands did you use for the following steps:

  • Scale up the cluster to 3 nodes and wait for it to be fully operational
  • Scale down the cluster back to 1 node

Also, did you possibly perform two Helm upgrade commands by chance? That could be wiping out the original settings.

from k8ssandra.

tomereli avatar tomereli commented on May 25, 2024

Hi @tomereli can you provide some more details for us to further investigate?

What commands did you use for the following steps:

  • Scale up the cluster to 3 nodes and wait for it to be fully operational
  • Scale down the cluster back to 1 node

Also, did you possibly perform two Helm upgrade commands by chance? That could be wiping out the original settings.

I used helm upgrade commands to scale up and down, according to the documentation:
scale up - https://k8ssandra.io/docs/topics/provision-a-cluster/#scale-up-the-cluster
scale down - https://k8ssandra.io/docs/topics/provision-a-cluster/#scale-down-the-cluster

What do you mean that it could be wiping out the original settings?

from k8ssandra.

jeffbanks avatar jeffbanks commented on May 25, 2024

Thanks for providing the details. I wanted to verify that those steps didn't override something previously set. I was referring to how multiple helm upgrades or two same key assignments can override the original intention.
helm upgrade --set foo=bar --set foo=baz k8ssandra ./k8ssandra

Helm upgrade reference

Given this detail, I will go through your exact steps and attempt to reproduce this locally.

from k8ssandra.

tomereli avatar tomereli commented on May 25, 2024

@tomereli Applying --set in the command line resets the previous settings to defaults. From helm help:

--reuse-values when upgrading, reuse the last release's values and merge in any overrides from the command line via --set and -f. If '--reset-values' is specified, this is ignored

Thus, your previous setting of:

--set ingress.traefik.enabled=true

If set to false after you applied the --set size=3. To keep the previous ingress values, you need to apply the --reuse-values to your later upgrades. So, the size upgrade would be:

helm upgrade k8ssandra-cluster-a k8ssandra/k8ssandra-cluster --set size=3 --reuse-values

That is assuming the behavior is the same as before as described better in this article:

https://medium.com/@kcatstack/understand-helm-upgrade-flags-reset-values-reuse-values-6e58ac8f127e

Well I guess this is it then - nice catch. I think it would be good to add this to the documentation, cause I guess more users may fall in this pitfall.

from k8ssandra.

burmanm avatar burmanm commented on May 25, 2024

@jeffbanks I think you were in process of verifying this? Could you send update to the doc or should I?

from k8ssandra.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.