Giter Club home page Giter Club logo

Comments (4)

qindazhu avatar qindazhu commented on August 18, 2024

I'll add swap tomorrow.

For composition, seems we can number the states when iterating over the queue,
https://github.com/danpovey/k2/blob/master/k2/csrc/fsa_algo.cc#L332-L333
I have no idea about its necessity in determinization for now.

Anyway, if it would be added, I prefer to add the constructor as a function with output-arg.

from k2.

csukuangfj avatar csukuangfj commented on August 18, 2024

what if there is a cycle and the fsa cannot be topsorted?

Abort?

from k2.

danpovey avatar danpovey commented on August 18, 2024

Firstly, we should have the top-sorting optional: we may sometimes want to just reorder the final-state so it's the last one.

I'd suggest to exit the program with a printed message if the user requested top-sorting and it couldn't be top-sorted. But don't make that dependent on debug level.

from k2.

csukuangfj avatar csukuangfj commented on August 18, 2024

we should have the top-sorting optional: we may sometimes want to just reorder the final-state so it's the last one.

what if the graph is not connected? In this case, how to determine which state is the final state?

from k2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.