Giter Club home page Giter Club logo

Comments (6)

v0dro avatar v0dro commented on August 26, 2024

And I think this issue arises only on ruby 2.2.0

from pi_piper.

jwhitehorn avatar jwhitehorn commented on August 26, 2024

My schedule doesn't give me enough time to really work on this project at the moment, but I'd gladly accept a pull request.

from pi_piper.

v0dro avatar v0dro commented on August 26, 2024

Sure thing!

Also could you tell me if there is anything specific that I should keep in mind during testing?

from pi_piper.

elmatou avatar elmatou commented on August 26, 2024

Same here, happend only with ruby 2.2.x . Eventmachine 1.0.4 (a later) fix this.

from pi_piper.

elmatou avatar elmatou commented on August 26, 2024

EventMachine dependency could be withdrawn.
It is only used for PiPiper#spi_poll which could be done with a simple sleep in a loop. Other Implementations, with EventMachine, Celluloid, Cool.io, Thread, Fiber.... should be done in application code.

from pi_piper.

zsyed91 avatar zsyed91 commented on August 26, 2024

I agree with @elmatou. If we can move this into the actual app code then it should reduce complexity of the gem. But anyhow, the current changes going into 1.9.9 which hopefully should be released in the next day or so contains the latest version of EventMachine. So this issue should be resolved once that is released. I am going to go ahead and close this.

from pi_piper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.