Giter Club home page Giter Club logo

Comments (6)

Jutho avatar Jutho commented on June 1, 2024

Your second example is irrelevant right? There you are doing a matrix vector multiplication. What seems to be missing is a multiplication with a scalar using the mul! interface. This works for arrays in LinearAlgebra, but a method seems to be missing for CuArrays. I think this is a CUDA.jl issue.

from krylovkit.jl.

Jutho avatar Jutho commented on June 1, 2024

However, it would arguably be good to have dedicated tests for testing KrylovKit.jl - CUDA.jl interoperability.

from krylovkit.jl.

RibeiroAndre avatar RibeiroAndre commented on June 1, 2024

I thought the second example was showing that mul! works on CuArrays in general, so I don't know why KrylovKit requires making changes to mul! in order to work.
I can file this under CUDA.jl if you think that's more appropriate, but I don't know how to reproduce the issue without using KrylovKit.

from krylovkit.jl.

Jutho avatar Jutho commented on June 1, 2024

Because it's another method signature, you are illustrating

mul!(::CuArray, ::CuArray, ::CuArray)

the error is from

mul!(::CuArray, ::CuArray, ::Number)

from krylovkit.jl.

RibeiroAndre avatar RibeiroAndre commented on June 1, 2024

Ah, yes. Clearly. Thanks for pointing that out. I'll file a CUDA ticket and you can decide if you want to close this one.
Thanks!

from krylovkit.jl.

RibeiroAndre avatar RibeiroAndre commented on June 1, 2024

Works on Julia Version 1.6.2, CUDA toolkit 11.1.1.

from krylovkit.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.