Hi there, thanks for this really cool project. I've been toying with it, and noticed t

Apparent memory leak under certain circumstances about quickjs-emscripten HOT 3 CLOSED

torywheelwright commented on May 30, 2024

Apparent memory leak under certain circumstances

from quickjs-emscripten.

Comments (3)

justjake commented on May 30, 2024

Thank you for the detailed bug report. I suspect the issue is that we don’t JS_FreeCString here:

quickjs-emscripten/c/interface.c

Line 429 in 8b17755

JS_FreeValue(ctx, enumerable_json);

I think this is a simple issue to fix, we need to strdup the result and the free it, then we can return the strdup string instead. QTS_GetString already does the right thing I think:

quickjs-emscripten/c/interface.c

Line 307 in 8b17755

char* result = strdup(owned);

can you try running your test generating and dumping big string values? That would validate the string copy logic is correct
Or, take a shot at making the change suggested above?

from quickjs-emscripten.

justjake commented on May 30, 2024

Hm my theory about strdup is wrong since this function is calling down to QTS_GetString already.

from quickjs-emscripten.

torywheelwright commented on May 30, 2024

Wow, thanks for fixing this so fast. So far so good!

from quickjs-emscripten.

Related Issues (20)

Tests fail on s390x machines HOT 5
Proxy log receiver blocking error HOT 1
Async Regression "TypeError: Object not disposable" in v0.26.0 HOT 4
wish to add a new api (QuickJSHandle.keepAlive) HOT 2
`getQuickJS()` callback never resolves? HOT 3
[vite - MIME type Error]It's cannot work in vite HOT 2
How to access wasm module's Memory? HOT 3
Feature request: Expose GetModuleExport APIs HOT 4
Timeout not working HOT 6
[feature request] Upgrade to v2024-01-13 HOT 3
TypeError: Failed to construct 'URL': Invalid URL HOT 7
Loading WasmMemory into module HOT 11
Determinism of the library HOT 2
Distributed packages have no license HOT 2
`evalCode` won't return error in ES module mode HOT 3
Can't run cloudflare example HOT 1
`Out of bounds memory access` Error only on ARM Safari HOT 10
Having troubles with ArrayBuffer HOT 1
Inconsistent behavior when running in browser (and web worker) HOT 2
In context of `QuickJSAsyncRuntime` and `QuickJSAsyncContext`, the `callFunction()` not working as expected HOT 7

Apparent memory leak under certain circumstances about quickjs-emscripten HOT 3 CLOSED

Comments (3)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent