Comments (1)
Thanks for submitting this issue! I agree with both the expected behavior and additional context points.
Without having implemented it yet, I think the following should be simple-ish to do:
- render
back_to_top
even iffooter_content
/*_edit_*
is not set- thing to look at: does this look good? unsure
- allow individual pages to override
back_to_top
(we've done this before w/ other site config variables) - document
back_to_top
- document that the footer will appear if at least one of
back_to_top
orfooter_content
or the*_edit_*
is specified
Does that seem like it properly captures the issue? If so, we can mark this as ready to implement, and I can add it to my backlog (time to complete is up-in-the-air) and/or have someone else take it on (e.g. you!).
From a bigger picture perspective, it would be great to eventually nest all of these keys under some sort of footer
key - that way, it would make it more clear that back_to_top
is dependent on the footer being rendered. Ex, I'm thinking something like this:
footer:
content: "Lorem ipsum..." # this would replace site.footer_content
back_to_top: true # this would replace site.back_to_top
# ditto for last_edit, gh_edit, ...
This would be a breaking change, so we'd probably have to defer to a v1. Broadly speaking, do you think this is a good idea?
from just-the-docs.
Related Issues (20)
- Add in-page right sidebar HOT 3
- `just-the-docs.com` copyright is out of date HOT 4
- big HOT 1
- Incorrect positioning of clickable area for navigation links in Safari/macOS HOT 6
- Add support for Lunr pre-built indexes HOT 3
- Zion LLC HOT 1
- Support CTRL+k shortcut for triggering the search input HOT 2
- Organize pages using IDs HOT 1
- Option to define groups with front matter HOT 3
- Log 2023-11-18 00_48_10.txt
- Searching _posts HOT 1
- Indented Markdown diff does not handle empty newlines HOT 2
- t
- Only first child in entire site gets expanded/shown in nav bar HOT 8
- How to manipulate DOM with code in `custom.js`? HOT 2
- UI breaking issue in landscape printing HOT 1
- Edit in Github link has extra slash when using collections with no permalink HOT 3
- custom.scss and setup.scss postprocessing issue HOT 4
- Search functionality is not working out of the box, zzzz-search-data.json is getting rendered as a HTML page instead of a JSON file HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from just-the-docs.