Pattern "**/*" Raises Folders Error about nodejs-eol-converter-cli HOT 5 CLOSED

Thanks, I am happy that this small utility is useful 😊 and thanks for report.

Looks like fix might be pretty easy - probably would be enough adding folder check in try/catch. Would you like to try make PR ?

from nodejs-eol-converter-cli.

Would you like to try make PR ?

I'm not all that versed in Node/JS. Most likely I could handle fixing this, but lack of practical experience might induce me to overlook some issues (especially on cross platform behavior)

But mainly, my PC just crashed a few days ago (thanks to Win 10 mandatory updates that break drivers) so I've just reinstalled my system from scratch and don't have yet all my working tools up and running again — but eolConverter was one of the top-priority tools in my restore TODOs list.

from nodejs-eol-converter-cli.

It was actually pretty easy fix, only glob modification. Fixed in version 1.0.8

from nodejs-eol-converter-cli.

Thanks a lot @jurosh !

Sorry if I didn't take a go at trying to implement it myself, but as mentioned above I don't have experience with Node.JS coding, and I wouldn't have a clear picture on the extensions environment.

from nodejs-eol-converter-cli.

It's never late to try that. It isn't hard and code review process by other devs (here me) might give you valuable feedback how to improve.. :)

from nodejs-eol-converter-cli.