Giter Club home page Giter Club logo

Comments (4)

lburgazzoli avatar lburgazzoli commented on August 18, 2024

I'd say that an option - default to true - would be the way to go, something like:

class EtcdNettyConfig {
    private boolean managedEventLoopGroup = true;

    public EtcdNettyConfig setEventLoopGroup(EventLoopGroup group) {
        return setEventLoopGroup(group, true);
    }

    public EtcdNettyConfig setEventLoopGroup(EventLoopGroup group, boolean managed) {
        this.eventLoopGroup = group;
        this.managedEventLoopGroup = managed;
        return this:
    }

    public boolean isManagedEventLoopGroup() {
        return managedEventLoopGroup;
    }
}

Would you like to contribute a PR ?

from etcd4j.

ytcoode avatar ytcoode commented on August 18, 2024

Hi, a new PR, check it!

from etcd4j.

lburgazzoli avatar lburgazzoli commented on August 18, 2024

I see two PR #98 and #99 and the later seems to have the same commit as the former , would you be so kind to squash the commits in one single PR ?

from etcd4j.

ytcoode avatar ytcoode commented on August 18, 2024

Done!

from etcd4j.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.