Giter Club home page Giter Club logo

Comments (3)

valderrama avatar valderrama commented on September 26, 2024

Seeing the same issue where the client closes but the process doesn't end because there's still a non-daemon thread hanging around, I believe line 18 in RetryPolicy is the culprit:

private static final HashedWheelTimer timer = new HashedWheelTimer();

Per the Netty documentation even though start was never explicitly called, stop() should be called on the timer object to clean up all the resources including this thread pool (from my jstack trace):

"pool-1-thread-1" #12 prio=0 os_prio=0 tid=0x0000 nid=0x0000 waiting on condition [0x0000]
   java.lang.Thread.State: TIMED_WAITING (sleeping)
    at java.lang.Thread.sleep(Native Method)
    at io.netty.util.HashedWheelTimer$Worker.waitForNextTick(HashedWheelTimer.java:461)
    at io.netty.util.HashedWheelTimer$Worker.run(HashedWheelTimer.java:360)
    at java.lang.Thread.run(Thread.java:745)

from etcd4j.

jurmous avatar jurmous commented on September 26, 2024

Thanks for the reporting in! I did not close HashedWheelTimer because it can be used by multiple etcd clients. It is advised to only have one in a App.
I now catch retried calls so they are canceled if they are still open if event loop is closed.

from etcd4j.

jurmous avatar jurmous commented on September 26, 2024

It is fixed in the 2.8 release.

from etcd4j.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.