Comments (4)
I have read the source code , now I know that the official documentation is wrong. The source code like this:
allow_2fa = Bool(
False,
config=True,
help=""
)
class SignUpHandler(LocalBase):
"""Render the sign in page."""
async def get(self):
if not self.authenticator.enable_signup:
raise web.HTTPError(404)
self._register_template_path()
html = self.render_template(
'signup.html',
ask_email=self.authenticator.ask_email_on_signup,
two_factor_auth=self.authenticator.allow_2fa,
)
self.finish(html)
Hence, If you set c.Authenticator.allow_2fa = True
, the problem should be solved.
from nativeauthenticator.
Also, the options.rst on minimum password length is wrong, which sets the attribute like this:
c.Authenticator.minimim_password_length = 10
However, it can not be recognized by nativeauthenticator for spelling mistake, the correct setting should be like this:
c.Authenticator.minimum_password_length = 10
from nativeauthenticator.
Thank you for opening your first issue in this project! Engagement like this is essential for open source projects!
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi!
Welcome to the Jupyter community!
from nativeauthenticator.
@xrdy511623 thanks for writing an issue about this and summarizing what the solution was! I'm opening it again until the documentation is fixed.
Issue summary
The documentation here use the wrong configuration name (add_two_factor_authentication
), it should be allow_2fa
.
nativeauthenticator/docs/options.rst
Line 122 in e66ef40
from nativeauthenticator.
Related Issues (20)
- Transition docs to use MyST? HOT 1
- Add docstring for handlers
- Better error reporting on failed signups with multiple problems.
- Replace Authorization Toggle by set-to-true and set-to-false.
- Misleading error message on incorrect 2FA token.
- docs: fix c.JupyterHub.template_paths HOT 1
- docs: fix c.JupyterHub.template_paths
- Confirmation email still sent for allow-listed users
- Enforce no slashes in usernames HOT 1
- Users created from the admin panel control hub are unusable due to lack of password when using NativeAuthenticator HOT 3
- Prepare for deprecation of Authenticator.db HOT 1
- Use user email as username HOT 1
- Release needed for JupyterHub 2 and 3 compatibility HOT 2
- import_from_firstuse not working: Previous users cannot log in or create an account. HOT 1
- Ability to set user environment path (bin folder) for users to use their own kernels HOT 1
- ci: our test system is failing
- '_xsrf' missing in login, signup and password changing pages HOT 1
- Planning for release 1.2.0 - JupyterHub 4 compatibility HOT 1
- Sign-Up email is not sent to admin for registration pending approval HOT 1
- locale.getdefaultlocale() is deprecated HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nativeauthenticator.