Giter Club home page Giter Club logo

Comments (7)

damianavila avatar damianavila commented on July 20, 2024

I agree... it could be some visual junk... removing anchors is an option... we can do it also by css I guess... we should explore both solutions...

from nbconvert.

akhmerov avatar akhmerov commented on July 20, 2024

As a hotfix, putting a.anchor-link{display:none} into custom.css removes them, but perhaps modifying the filters would be a cleaner solution. Reveal is quite reasonable to edit in source, which means there's merit in keeping the source code minimal.

from nbconvert.

damianavila avatar damianavila commented on July 20, 2024

As a hotfix, putting a.anchor-link{display:none}

Yes, this is the fix we use in RISE, although I agree the other solution can be cleaner... but less "customizable" also. I guess I will explore the filter solution to see if I am happy enough 😉

from nbconvert.

akhmerov avatar akhmerov commented on July 20, 2024

Seems like making a subclassed IPythonRenderer by removing add_anchor from https://github.com/jupyter/nbconvert/blob/master/nbconvert/filters/markdown_mistune.py#L105 should be sufficient. Unfortunately I don't quite have time to figure out how to install the master of everything, and I don't know where the modification would belong.

from nbconvert.

damianavila avatar damianavila commented on July 20, 2024

Yes, it is a possible solution... but I feel it adds too much complexity for something easy to fix with one line css modification in the slides_reveal template...

from nbconvert.

akhmerov avatar akhmerov commented on July 20, 2024

It's probably under 10 lines of code, and it does produce cleaner output. The reveal output already has multiple css overrides, and piling them up seems a fragile implementation.

from nbconvert.

damianavila avatar damianavila commented on July 20, 2024

Well... fragile as any of the other css overrides... but ok, maybe I thinking this in a complex way? I will try to research into your idea...

from nbconvert.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.