Giter Club home page Giter Club logo

Comments (7)

kevin-bates avatar kevin-bates commented on May 24, 2024 1

This sounds really interesting. So a given EG server would still target exactly one Kubernetes cluster in which the kernels are launched - these changes simply enable the ability for that cluster to be remote. Is that correct?

You'll also need to take into account the possibility of the user having configured the EG_SHARED_NAMESPACE functionality. In that case, the remote cluster may not have the enterprise-gateway namespace and I would argue that we should probably raise an error if remote-k8s-cluster AND eg-shared-namespace are both enabled. The BYO namespace (using KERNEL_NAMESPACE) should still work, although we should probably ensure that KERNEL_NAMESPACE does not reflect the EG namespace in which EG resides.

At any rate, those are implementation details that we can work out. We look forward to your pull request.

(Just a note that changes within the Process Proxies functionality, will be dropped in our EG 4.0 release in favor of using the kernel provisioner framework that is now part of the general Jupyter stack, so it would be great if you can participate in the Gateway Provisioners project. I'm (frantically) trying to get things in place for a release over there as we speak. If you're unable to make applicable changes, no worries, we'll port them over at some point closer to making the switch. I just wanted to make you aware of that future transition.)

from enterprise_gateway.

kevin-bates avatar kevin-bates commented on May 24, 2024 1

Yes - you opened #1208. 😄

from enterprise_gateway.

welcome avatar welcome commented on May 24, 2024

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

from enterprise_gateway.

Shrinjay avatar Shrinjay commented on May 24, 2024

So a given EG server would still target exactly one Kubernetes cluster in which the kernels are launched - these changes simply enable the ability for that cluster to be remote. Is that correct?

Yup! That would be exactly correct.

Thanks for reminding me about the shared namespace option! That's something I forgot to consider, I'll also look through the other k8s options to ensure we don't raise a conflict.

In regards to the new gateway provisioners, thanks for making me aware of that as well. I'll take a look there for the effort to port over the new k8s client pattern w remote cluster and let you know.

from enterprise_gateway.

kevin-bates avatar kevin-bates commented on May 24, 2024

I'll take a look there for the effort to port over the new k8s client pattern w remote cluster and let you know.

You should find things nearly identical with the exception of name changes and the fact that there isn't a hosting application in the repo.

I need to apologize for the existing documentation (still converting from EG), tests (that are nearly zero), and lack of an installable package (hopefully soon), so bear with us.

from enterprise_gateway.

echarles avatar echarles commented on May 24, 2024

I need to apologize for the existing documentation (still converting from EG), tests (that are nearly zero), and lack of an installable package (hopefully soon), so bear with us.

Is there an issue or PR that tracks the effort to let EG use the Provisioners?

from enterprise_gateway.

sa- avatar sa- commented on May 24, 2024

So a given EG server would still target exactly one Kubernetes cluster in which the kernels are launched

It would be useful if one could also point to a specific kube context for a given kernel

from enterprise_gateway.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.