Comments (2)
Considering that the two main functions that start an integration (executeIntegrationInstance
and initiateSynchronization
) accept an input logger, I'm thinking it might make a little more sense to have the accountId
and integrationInstanceId
be immediately added to the logger once it is created in our managed runtime environment instead of here in the sdk.
from sdk.
immediately added to the logger once it is created in our managed runtime environment instead of here in the sdk.
I think this is definitely the right place to do it. @philidem, you'll see that it can be easily added here https://bitbucket.org/lifeomic/jupiter-integration-qualys/src/c118dee650ae573cd2451f9f80d40c25f01296c3/src/lambda/index.ts#lines-37, and we'll be sure the runtime library carries that on for all the integrations.
from sdk.
Related Issues (20)
- Deprecate `convertProperties` HOT 1
- Add an additional type of error for when we exceed retries/quotas HOT 4
- Support supplying an API base URL in CLI commands HOT 3
- Add documentation for `j1` CLI
- Failing to publish integration event does not include system error response details
- Update `jobState.hasKey` documentation to cover edge case
- Entities and relationships should have consumable information about the properties on them
- Add `inspect` command or flag to integration CLI
- `createIntegrationEntity` should take Typescript Generic HOT 1
- Integration step failure events do not expose original authorization or authentication errors HOT 1
- Introduce `beforeAddRelationship` hook into `IntegrationInvocationConfig` HOT 1
- Support async `beforeAddRelationship` HOT 1
- Introduce `deferUploads` option to step.
- onRelationshipsFlushed, onEntitiesFlushed possible unnecessarily locking? HOT 2
- Decouple the size of storage files from the size of the `GRAPH_OBJECT_BUFFER` HOT 1
- v9.0.0 Ideas HOT 3
- `j1-integration run` command results in `Unauthorized` when pointing to JupiterOne host
- Support YAML environment file
- Allow certain error codes in recordings
- Need logger in loadExecutionConfig
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sdk.