NPE on a possibly corrupt rar file about junrar HOT 7 CLOSED

your file format is broken up. you can use winrar to test it.

from junrar.

Indeed the file is corrupt:

rar t some-corrupt-file.rar                                                                                                                                  Thu Jul 16 10:27:00 2020

RAR 5.91   Copyright (c) 1993-2020 Alexander Roshal   25 Jun 2020
Trial version             Type 'rar -?' for help

Corrupt header is found
Main archive header is corrupt

Testing archive some-corrupt-file.rar

Corrupt header is found
No files to extract

It would make sense indeed to handle this and throw a RarException instead of a NPE. I'll see if I can add this.

from junrar.

@gotson
hi gotson ,i've found the problematic code,please merge my prior PR soon. so i can create new PR for this

from junrar.

@gotson
hi gotson ,i've found the problematic code,please merge my prior PR soon. so i can create new PR for this

Thanks. Can you maybe add a test with the provided file in the PR as well as the code fix?

from junrar.

ok,I use sparkhi‘s data as test data, is that ok?

from junrar.

ok,I use sparkhi‘s data as test data, is that ok?

yes!

from junrar.

🎉 This issue has been resolved in version 5.0.0 🎉

The release is available on:

• v5.0.0
• GitHub release

Your semantic-release bot 📦🚀

from junrar.