Comments (5)
I also ran into this issue. Atom no longer saves the window size and position on my Mac (El Capitan) upon closing. When I disable the Ink package, everything works as expected.
from atom-ink.
This is due to those lines -- no clue why this should change anything about the window size though.
Seems a bit like a bug in Atom: Similar calls involving editors, e.g. atom.workspace.getTextEditors()
, change the window size as well when called in the activate
function.
Possibly related: atom/atom#9664
from atom-ink.
Those lines have been there for a while, but perhaps they're interacting badly with the new deserialisation code? Either way, editors actually already have IDs, so we should just replace that code.
from atom-ink.
IIRC this issue has been around for quite a while as well (at least for me, but I just never attributed it to ink).
from atom-ink.
Yeah, I don't quite know why I thought those lines were the culprit -- can't reproduce the behaviour I saw when testing a few days back.
That said, I'm pretty sure this is because of those lines now -- what's the failure mode this is supposed to address, @MikeInnes? I don't see any (de)serialisation problems with the console or whatever when commenting this out, but of course I don't know what to look for anyways...
from atom-ink.
Related Issues (20)
- Uncaught NotFoundError: Failed to execute 'insertBefore' on 'Node': The node before which the new... HOT 1
- Uncaught TypeError: Cannot read property 'props' of undefined HOT 4
- Uncaught TypeError: Cannot read property 'props' of undefined HOT 2
- Uncaught TypeError: Cannot read property 'props' of undefined HOT 1
- Uncaught TypeError: Cannot read property 'props' of undefined HOT 7
- Cannot install ink v0.11.5 HOT 4
- [BUG] Atom update 1.40.1 did not rectify ink installation failure issue for me
- Installing “[email protected]” failed HOT 2
- Uncaught TypeError: Cannot read property 'setCellFromCodePoint' of undefined
- Uncaught TypeError: Cannot read property 'loadCell' of undefined
- Uncaught Error: No option with key "cursorWidth" HOT 4
- Uncaught Error: write data discarded, use flow control to avoid losing data HOT 4
- Uncaught TypeError: Cannot read property 'decorateMarker' of null
- Uncaught TypeError: this.scopes.some is not a function HOT 3
- [BUG] [email protected] seems to contain a bug HOT 2
- [performance] Removing dependencies / splitting the package
- Uncaught TypeError: Cannot read property 'highlight' of undefined
- Uncaught Error: This API only accepts integers
- Uncaught Error: write data discarded, use flow control to avoid losing data
- HTMLDocument.registerElement is deprecated.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from atom-ink.