libxo output breaks if buffer exceeds 8kb about libxo HOT 4 CLOSED

I could be wrong, but it looks like the problem is caused by the call to xo_buf_has_room() not considering some part of the pretty printing:

ALLAN: xo_buf_has_room: xb_size: 8192, curp: 8154, len: 12
ALLAN: xo_buf_has_room: xb_size: 8192, curp: 8166, len: 1
ALLAN: xo_buf_has_room: xb_size: 8192, curp: 8167, len: 5
ALLAN: xo_buf_has_room: xb_size: 8192, curp: 8172, len: 2
ALLAN: xo_buf_has_room: xb_size: 8192, curp: 8174, len: 1
ALLAN: xo_buf_has_room: xb_size: 8192, curp: 8175, len: 5
ALLAN: xo_buf_has_room: xb_size: 8192, curp: 8212, len: 12
ALLAN: Expanded buffer
ALLAN: xo_buf_has_room: xb_size: 16384, curp: 8224, len: 1
ALLAN: xo_buf_has_room: xb_size: 16384, curp: 8225, len: 4

It doesn't appear to expand the buffer until the cur pointer has passed the end of the buffer.

from libxo.

Could you please retry with the current code? I fixed an embarrassingly bad issue in xo_vsnprintf:

• if (rc > xbp->xb_size) {
• if (rc >= left) {

in commit 1f66642 that’s part of libxo-0.3.3. IIRC the fix is in 0.3.2 also.

But I’m fairly confident this was the issue you are seeing.

Thanks,
Phil

On May 4, 2015, at 12:40 AM, Allan Jude [email protected] wrote:

I could be wrong, but it looks like the problem is caused by the call to xo_buf_has_room() not considering some part of the pretty printing:

ALLAN: xo_buf_has_room: xb_size: 8192, curp: 8154, len: 12
ALLAN: xo_buf_has_room: xb_size: 8192, curp: 8166, len: 1
ALLAN: xo_buf_has_room: xb_size: 8192, curp: 8167, len: 5
ALLAN: xo_buf_has_room: xb_size: 8192, curp: 8172, len: 2
ALLAN: xo_buf_has_room: xb_size: 8192, curp: 8174, len: 1
ALLAN: xo_buf_has_room: xb_size: 8192, curp: 8175, len: 5
ALLAN: xo_buf_has_room: xb_size: 8192, curp: 8212, len: 12
ALLAN: Expanded buffer
ALLAN: xo_buf_has_room: xb_size: 16384, curp: 8224, len: 1
ALLAN: xo_buf_has_room: xb_size: 16384, curp: 8225, len: 4

It doesn't appear to expand the buffer until the cur pointer has passed the end of the buffer.

—
Reply to this email directly or view it on GitHub #37 (comment).

from libxo.

I have 0.3.2 with that fix.

The issue seems to be that the exact same bug exists in:
xo_printf_v()

ALLAN: xo_buf_has_room: xb_size: 8192, curp: 8166, len: 1
ALLAN: xo_buf_has_room: xb_size: 8192, curp: 8167, len: 5
ALLAN: xo_buf_has_room: xb_size: 8192, curp: 8172, len: 2
ALLAN: xo_buf_has_room: xb_size: 8192, curp: 8174, len: 1
ALLAN: xo_buf_has_room: xb_size: 8192, curp: 8175, len: 5
ALLAN: xo_printf_v: wrote 12 of 12 bytes
ALLAN: xo_printf_v: wrote 20 of 0 bytes
ALLAN: xo_buf_has_room: xb_size: 8192, curp: 8212, len: 12
ALLAN: Expanding Buffer
ALLAN: xo_buf_has_room: xb_size: 16384, curp: 8224, len: 1
ALLAN: xo_buf_has_room: xb_size: 16384, curp: 8225, len: 4

from libxo.

Fixed in 0.3.4

from libxo.