Windows: Mouse-clicking doesn't work properly in bash about fzf HOT 1 CLOSED

There are two renderer implementations for Windows.

1. FullscreenRenderer. Based on tcell library. We use this in fullscreen mode.
2. LightRenderer. It was added later to support --height and used only when --height option is given.

FullscreenRenderer

• Mouse works on cmd.exe
• Mouse doesn't work on mintty
  • Seems to be a limitation of tcell. gdamore/tcell#133 (comment)

LightRenderer

• Mouse works on cmd.exe
• Mouse works on mintty, but click position is broken. Fixed in 0684a20

So with 0684a20, mouse works properly when --height is used on mintty, but not in fullscreen mode. We can fix this by always using LightRenderer.

diff --git a/src/terminal.go b/src/terminal.go
index 128da4e..7307c17 100644
--- a/src/terminal.go
+++ b/src/terminal.go
@@ -711,7 +711,7 @@ func NewTerminal(opts *Options, eventBox *util.EventBox, executor *util.Executor
 		}
 	}
 	if fullscreen {
-		if tui.HasFullscreenRenderer() {
+		if !tui.IsLightRendererSupported() {
 			renderer = tui.NewFullscreenRenderer(opts.Theme, opts.Black, opts.Mouse)
 		} else {
 			renderer, err = tui.NewLightRenderer(ttyin, opts.Theme, opts.Black, opts.Mouse, opts.Tabstop, opts.ClearOnExit,

It's a simple change, and I can confirm that it fixes the mouse problem. However, I'm not sure if there are any unwanted side effects. I could use some help testing the binary.

fzf.exe.zip

from fzf.