Checklist <input type

The last fzf version which supports this version of zsh is <code class="n

Broken zsh shell integration on 0.51+ about fzf HOT 1 CLOSED

ecanessa commented on July 17, 2024

Broken zsh shell integration on 0.51+

from fzf.

Comments (1)

LangLangBart commented on July 17, 2024 1

The last fzf version which supports this version of zsh is 0.50.0 (f97d275)

I believe the issue has been introduced through commit f864f8b.

I can confirm the problem occurs with any version up to 5.1, and the change was implemented in a commit¹, which introduced improved assignment handling in zsh for builtin commands such as export.

zsh-5.0.2 ❌

❯ ~/.local/zsh-test/bin/zsh-5.0.2 -fxvc 'export TEST=$(echo "--height 40% --reverse --scheme=path")'
+zsh:1> echo '--height 40% --reverse --scheme=path'
+zsh:1> export 'TEST=--height' 40% --reverse '--scheme=path'
zsh:export:1: not an identifier: 40%

zsh-5.1 ✅

❯ ~/.local/zsh-test/bin/zsh-5.1 -fxvc 'export TEST=$(echo "--height 40% --reverse --scheme=path")'
export TEST=$(echo "--height 40% --reverse --scheme=path")
+zsh:1> echo '--height 40% --reverse --scheme=path'
+zsh:1> export TEST='--height 40% --reverse --scheme=path'

Does splitting declaration and assignment solve the issue for you?

--- a/shell/completion.zsh
+++ b/shell/completion.zsh
@@ -158,5 +158,6 @@ __fzf_generic_path_completion() {
       [ "$dir" != "/" ] && dir="${dir/%\//}"
       matches=$(
-        export FZF_DEFAULT_OPTS=$(__fzf_defaults "--reverse --scheme=path" "${FZF_COMPLETION_OPTS-}")
+        export FZF_DEFAULT_OPTS
+        FZF_DEFAULT_OPTS=$(__fzf_defaults "--reverse --scheme=path" "${FZF_COMPLETION_OPTS-}")
         unset FZF_DEFAULT_COMMAND FZF_DEFAULT_OPTS_FILE
         if declare -f "$compgen" > /dev/null; then