Comments (8)
jumaallan
commented on August 17, 2024
I think for the sample project, we should not use any DI. This will make the example easy to use by anyone who wants to learn how the library works
from android-mpesa-api.
wangerekaharun
commented on August 17, 2024
I think for the sample project, we should not use any DI. This will make the example easy to use by anyone who wants to learn how the library works
with this in mind you should probably close this issue
from android-mpesa-api.
jumaallan
commented on August 17, 2024
This issue was meant to change the DI inside the library module itself, not the sample app
from android-mpesa-api.
wangerekaharun
commented on August 17, 2024
Seen the library module doesn't have any DI
from android-mpesa-api.
jumaallan
commented on August 17, 2024
Yeah, the re-write was going to use KOIN maybe, or we can just do away with the DI concept on the module
from android-mpesa-api.
jumaallan
commented on August 17, 2024
@andronicus-kim Feel free to contribute to this conversation
from android-mpesa-api.
andronicus-kim
commented on August 17, 2024
I think introducing DI on the module will make it a lot cleaner.
from android-mpesa-api.
jumaallan
commented on August 17, 2024
Great. Let's continue working from your current PR
from android-mpesa-api.
Related Issues (20)
- Docs Add: code of conduct and contributor guidelines HOT 2
- Migrate from Circle CI to Github Actions
- Add Tests [Unit Tests and Instrumentation Tests] HOT 1
- JCenter Migration HOT 5
- Upgrade to AGP 7 HOT 1
- Updated CI to support Java 11
- Update README
- Generate Library Code Documentation HOT 3
- ktLint is failing [Old dependencies maybe]
- Migrate to mavenCentral()
- Toast Activity when the token is received HOT 1
- [Security] Is this library secure? HOT 2
- Could not find com.androidstudy:daraja:2.0.0. HOT 2
- Migrate from GSON to Moshi/kotlinx.serialization
- Bad Request - Invalid BusinessShortCode HOT 4
- Error after stk push.
- Authentication Request Failure rate
- :sparkles: Create unit tests for the api HOT 7
- :bomb: Broken url
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from android-mpesa-api.