ENOPACKAGENAME No name for the package defined. about semantic-release-slack-bot HOT 9 CLOSED

Do you run semantic release with npx? Because if so, the plugin will not detect your package name.

from semantic-release-slack-bot.

Yes the problem is probably that we read npm_package_name when there probably exists a better variable given from the context. I am quite sure that other plugins work while doing npx and as this plugin is in the later stages the package name should be figured out when it's our time to execute.

from semantic-release-slack-bot.

Maybe we could do something similar 🤷

from semantic-release-slack-bot.

from semantic-release-slack-bot.

Yes, I don't know why this is a problem. We probably read the package name in a suboptimal way cause other plugins work with npx. I warmly welcome a PR that fixes this issue 😁

from semantic-release-slack-bot.

Easy enough to add. But what should the precedence rules look like? We'll have four ways of providing the package name.

Environment variable
package.json
Config setting
npm_package_name <- not sure where this comes from 🤔

@juliuscc

from semantic-release-slack-bot.

The github plugin gets relases from context and then gets release.name from them.

See:

• https://github.com/semantic-release/github/blob/1ef0a6d438a6949bbd654ce080d67ec33753409e/lib/get-success-comment.js#L12
• https://github.com/semantic-release/github/blob/1ef0a6d438a6949bbd654ce080d67ec33753409e/lib/success.js#L84
• https://github.com/semantic-release/github/blob/1ef0a6d438a6949bbd654ce080d67ec33753409e/lib/success.js#L45
• https://github.com/semantic-release/github/blob/1ef0a6d438a6949bbd654ce080d67ec33753409e/lib/success.js#L20

from semantic-release-slack-bot.

@juliuscc Do you have plans to fix that issue?

from semantic-release-slack-bot.

This is not a high priority task IMO as there are quite simple workarounds. I do however welcome PR's that fix this. If you need any more assistance than the hints above, I will gladly help 😁

from semantic-release-slack-bot.